Refactor edition controller test helper into separate concerns#11018
Closed
ryanb-gds wants to merge 1 commit into
Closed
Refactor edition controller test helper into separate concerns#11018ryanb-gds wants to merge 1 commit into
ryanb-gds wants to merge 1 commit into
Conversation
This has two benefits. Firstly, we don't have to navigate a several thousand line helper file to find out what our tests are doing. Secondly, we now run individual tests from the concerns for a particular test case, e.g. with `rails test test/functional/admin/publications_controller_test.rb -n "editing an existing edition should record a RecentEditionOpening"`, which wasn't possible before as the tests were wrapped in method calls.
ryanb-gds
force-pushed
the
controller-test-helper-refactor
branch
from
04215a3 to
25d1428
Compare
Contributor
Author
|
Closing this as nobody can realistically review it, the amount of change is too high. Was really just experimenting to see what Gemini CLI could do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has two benefits. Firstly, we don't have to navigate a several thousand line helper file to find out what our tests are doing.
Secondly, we now run individual tests from the concerns for a particular test case, e.g. with
rails test test/functional/admin/publications_controller_test.rb -n "editing an existing edition should record a RecentEditionOpening", which wasn't possible before as the tests were wrapped in method calls.