Move version of images to ImageData from ImageUploader#11172
Draft
patrickpatrickpatrick wants to merge 2 commits intomainfrom
Draft
Move version of images to ImageData from ImageUploader#11172patrickpatrickpatrick wants to merge 2 commits intomainfrom
version of images to ImageData from ImageUploader#11172patrickpatrickpatrick wants to merge 2 commits intomainfrom
Conversation
patrickpatrickpatrick
changed the base branch from
main
to
alt-aspect-ratios
patrickpatrickpatrick
force-pushed
the
alt-aspect-ratios
branch
2 times, most recently
from
4dc8f26 to
feb612e
Compare
patrickpatrickpatrick
force-pushed
the
alt-aspect-ratios
branch
from
feb612e to
b52b6ca
Compare
patrickpatrickpatrick
force-pushed
the
landing-pages-new-crop
branch
from
6461cd1 to
63bc04b
Compare
patrickpatrickpatrick
force-pushed
the
alt-aspect-ratios
branch
from
b52b6ca to
123dbfa
Compare
patrickpatrickpatrick
force-pushed
the
landing-pages-new-crop
branch
from
63bc04b to
3fb072e
Compare
patrickpatrickpatrick
force-pushed
the
alt-aspect-ratios
branch
from
123dbfa to
e68f81a
Compare
patrickpatrickpatrick
force-pushed
the
landing-pages-new-crop
branch
from
3fb072e to
817d8d3
Compare
patrickpatrickpatrick
changed the title
patrickpatrickpatrick
force-pushed
the
alt-aspect-ratios
branch
6 times, most recently
from
c00ddf1 to
01b928b
Compare
patrickpatrickpatrick
force-pushed
the
landing-pages-new-crop
branch
2 times, most recently
from
7aa6fb1 to
232d662
Compare
patrickpatrickpatrick
force-pushed
the
alt-aspect-ratios
branch
11 times, most recently
from
f8b0e56 to
14cc63f
Compare
patrickpatrickpatrick
force-pushed
the
alt-aspect-ratios
branch
13 times, most recently
from
c824b18 to
a1d81d0
Compare
lauraghiorghisor-tw
force-pushed
the
alt-aspect-ratios
branch
from
a1d81d0 to
410d070
Compare
patrickpatrickpatrick
force-pushed
the
alt-aspect-ratios
branch
from
410d070 to
82d6f26
Compare
patrickpatrickpatrick
force-pushed
the
landing-pages-new-crop
branch
from
563300f to
ac5a17d
Compare
patrickpatrickpatrick
force-pushed
the
landing-pages-new-crop
branch
4 times, most recently
from
9541b78 to
ae6a2d9
Compare
patrickpatrickpatrick
changed the title
version of images to ImageData from ImageUploader
patrickpatrickpatrick
force-pushed
the
landing-pages-new-crop
branch
from
ae6a2d9 to
d88f87b
Compare
patrickpatrickpatrick
force-pushed
the
landing-pages-new-crop
branch
4 times, most recently
from
0518f68 to
a5656af
Compare
patrickpatrickpatrick
force-pushed
the
landing-pages-new-crop
branch
from
a5656af to
fcd2f79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move
versioncreation toImageDatafromImageUploaderWhy
Each image kind can now have the same name. Before versions were declared on the same
ImageUploaderclass, which meant that if versions were specified with the same name in the config then they would conflict.This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.