Remove legacy topical events [WHIT-3059]#11192
Draft
ChrisBAshton wants to merge 3 commits intomainfrom
Draft
Conversation
acb1aed to
af52572
Compare
e65cf3a to
2ae7f96
Compare
2c002a0 to
4b91716
Compare
2ae7f96 to
3fb7ecc
Compare
4f787da to
07fa26f
Compare
09bd626 to
a1a3cb2
Compare
e639989 to
724f05a
Compare
bb936f1 to
ecab08a
Compare
724f05a to
e81f255
Compare
af477e3 to
f356782
Compare
c564c8d to
ddee9d4
Compare
41e0eb8 to
030ec57
Compare
4fbb573 to
7ec7fe5
Compare
2851051 to
e4d7227
Compare
None of its behaviour needs carrying over to config driven topical events.
This looks like it would only be used by content types that update Search API directly. But all classes that include Edition::TopicalEvents inherit from Edition, which updates Search API the idiomatic way via Publishing API, so I don't think this method is doing anything.
7ec7fe5 to
3187568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit
The audit of existing tests for topical events led to three other housekeeping / preparatory PRs:
In addition we've identified the following legacy behaviour and remediation steps:
46a7798#diff-aebdda5489e75983ed804d3897bf708fadde13cd52b6815c31d25ddbf0254aaeR55-R56, with no clear reason for it
republish_feature_organisations_to_publishing_apinot needed - it happens automatically now through link expansion 🎉What
The purpose of this PR is to audit the existing legacy topical event code to ensure all functionality has been considered and either carried over or deliberately omitted. The aim is to end up with a draft PR that deletes all legacy topical event code, and a passing CI build. This should make legacy topical event code deletion much smoother.
NB, we'd then need to raise a PR to drop the following database tables:
topical_eventstopical_event_organisationstopical_event_membershipstopical_event_featuringstopical_event_featuring_image_datatopical_event_about_pages...and drop
topical_event_idfrom thefeaturestable.Their behaviour would now be encapsulated in the "editions" table and "edition_links" and "feature_lists"/"features" tables (and whatever tables we introduce for multi-page architecture).
Why
Jira: https://gov-uk.atlassian.net/browse/WHIT-3059
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.