Draft
Conversation
We're looking to add a 'read only tabs' feature for non-draft editions, which will require dropping these actions from the card component. Moving the action population out of the view is the first step to achieving that. This commit also adds missing tests for that view logic.
We're looking to add a 'read only tabs' feature for non-draft editions, which will require dropping these actions from the card component. Moving the action population out of the view is the first step to achieving that. This commit also adds missing tests for that view logic.
This enables 'read-only' view of the Images tab
We'd disabled this before because all tabs other than Document did not yet have 'read-only' mode enabled. That is no longer the case and we should allow publishers to navigate to the different read-only tabs to see what content they have set in each place.
We want to warn the publisher on every tab that the content is not editable.
This is so we can surface a read-only view for showing publishers the features on a published edition.
ChrisBAshton
force-pushed
the
read-only-tabs
branch
from
bfc6a6e to
26cd742
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
In #10332, we introduced a 'read-only' version of the main document summary tab, to allow publishers to see what values / contents they had set without having to create a new draft edition to see it(!).
That was only partly useful, because a lot of the content of a document is tucked away on other screens, e.g. Images tab. So this PR extends the 'read-only' concept more widely.
This also solves an issue whereby it was possible to make edits to offsite links directly from the published tab screen, thereby editing offsite links without going through the draft creation process.
Jira: https://gov-uk.atlassian.net/browse/WHIT-3152
Screenshots
Social media accounts tab
Images tab
Features tab - Currently Featured
Features tab - GOV.UK content
Features tab - External websites
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.