Validate each document tab form separately [WHIT-3214]

app/components/admin/editions/show/preview_component.html.erb

@@ -11,6 +11,11 @@
     <p class="govuk-body">
       <%= preview_link(primary_locale_link_text, local_edition.public_url(draft: true)) %>
     </p>
+    <% if local_edition.is_a?(StandardEdition) && invalid_tab_forms&.any? %>
+      <p class="govuk-hint">
+        This preview may be out of date. Kindly fix the errors in the invalid tabs before the preview reflects your latest changes.
+      </p>
+    <% end %>
 
     <% if available_in_multiple_languages %>
       <% translation_preview_links = local_edition.non_primary_translation_locales.map do |locale|

app/components/admin/editions/show/preview_component.rb

@@ -3,8 +3,9 @@
 class Admin::Editions::Show::PreviewComponent < ViewComponent::Base
   include Admin::UrlOptionsHelper
 
-  def initialize(edition:)
+  def initialize(edition:, invalid_tab_forms: [])
     @edition = edition
+    @invalid_tab_forms = invalid_tab_forms
   end
 
   def render?
@@ -13,7 +14,7 @@ def render?
 
 private
 
-  attr_reader :edition
+  attr_reader :edition, :invalid_tab_forms
 
   def versioning_completed
     @versioning_completed ||= edition.versioning_completed?

app/controllers/admin/standard_editions_controller.rb

@@ -38,8 +38,26 @@ def apply_change_type
   end
 
   def update
-    @edition.current_tab_context = @current_tab_context
-    super
+    @edition.assign_attributes(edition_params)
+
+    if @current_tab_context.present?
+      tab_form = StandardEdition::TabForm.new(@edition, @current_tab_context)
+
+      if tab_form.valid?
+        @edition.save_as(current_user, validate: false)
+        redirect_to redirect_param(fallback: show_or_edit_path), saved_confirmation_notice
+      else
+        apply_tab_errors_to_edition(tab_form)
+        build_edition_dependencies
+        fetch_version_and_remark_trails
+        construct_similar_slug_warning_error
+        render :edit
+      end
+    else
+      # non-tabbed forms in standard edition, or non-tab pages like translations
+      @edition.current_tab_context = nil
+      super
+    end
   end
 
   def features
@@ -65,6 +83,15 @@ def features
     render :features
   end
 
+  def show
+    super
+    type_instance = @edition.type_instance
+    @invalid_tab_forms = type_instance.form_keys.filter_map do |tab_key|
+      tab_form = StandardEdition::TabForm.new(@edition, tab_key)
+      { tab_key:, label: type_instance.form(tab_key)["label"] || tab_key.humanize } unless tab_form.valid?
+    end
+  end
+
 private
 
   def edition_class
@@ -89,6 +116,11 @@ def show_or_edit_path
     end
   end
 
+  def apply_tab_errors_to_edition(tab_form)
+    @edition.errors.clear
+    tab_form.errors.each { |e| @edition.errors.add(e.attribute, e.message) }
+  end
+
   def render_not_found
     render "admin/errors/not_found", status: :not_found
   end

app/models/concerns/edition/workflow.rb

@@ -100,8 +100,8 @@ def pre_publication?
     Edition::PRE_PUBLICATION_STATES.include?(state.to_s)
   end
 
-  def save_as(user)
-    if save
+  def save_as(user, options = {})
+    if save(**options)
       edition_authors.create!(user:)
       recent_edition_openings.where(editor_id: user).delete_all
     end

app/models/concerns/standard_edition/tab_form.rb

@@ -0,0 +1,65 @@
+class StandardEdition::TabForm
+  include ActiveModel::Model
+
+  attr_reader :edition, :tab_key
+
+  validate :validate_block_content
+  validate :validate_edition_fields, if: -> { edition_attribute_keys.any? }
+
+  ADDITIONAL_DEFAULT_TAB_FIELDS = %w[title summary].freeze
+
+  def initialize(edition, tab_key)
+    @edition = edition
+    @tab_key = tab_key
+  end
+
+private
+
+  def form_config
+    @form_config ||= edition.type_instance.form(tab_key).tap do |config|
+      raise ArgumentError, "Unknown tab key '#{tab_key}'" unless config
+    end
+  end
+
+  # Fields whose data lives inside block_content (e.g. "body", "social_media_links")
+  def block_content_field_keys
+    (form_config["fields"] || {}).filter_map do |_key, field|
+      attr_path = Array(field["attribute_path"])
+      attr_path.last if attr_path.first == "block_content"
+    end
+  end
+
+  # Fields whose data lives directly on the edition (e.g. "lead_organisation_ids")
+  def edition_attribute_keys
+    keys = (form_config["fields"] || {}).filter_map do |_key, field|
+      attr_path = Array(field["attribute_path"])
+      attr_path.first unless attr_path.first == "block_content"
+    end
+
+    tab_key == edition.default_tab ? keys + ADDITIONAL_DEFAULT_TAB_FIELDS : keys # Need to move these fields into document form configuration
+  end
+
+  def scoped_block_content
+    schema = edition.type_instance.schema_for_fields(block_content_field_keys)
+    StandardEdition::BlockContent.new(schema).tap do |bc|
+      bc.assign_attributes(edition[:block_content] || {})
+    end
+  end
+
+  def validate_block_content
+    block_content = scoped_block_content
+    return if block_content.valid?(validation_context)
+
+    block_content.errors.each { |error| errors.import(error, attribute: error.attribute.to_s) }
+  end
+
+  def validate_edition_fields
+    edition.current_tab_context = tab_key
+    edition.valid?(validation_context)
+    edition.current_tab_context = nil
+
+    edition_attribute_keys.each do |attr|
+      edition.errors.where(attr.to_sym).each { |error| errors.import(error, attribute: error.attribute.to_s) }
+    end
+  end
+end

app/models/configurable_document_type.rb

@@ -103,6 +103,10 @@ def form(key = nil)
     end
   end
 
+  def form_keys
+    @forms.keys
+  end
+
   def presenter(key)
     @presenters[key]
   end

app/models/standard_edition.rb

@@ -115,15 +115,18 @@ def group
   end
 
   def organisation_association_enabled?
-    field_paths.include?(ConfigurableContentBlocks::Path.new("lead_organisation_ids"))
+    current_tab_context_includes_field?("lead_organisation_ids") &&
+      field_paths.include?(ConfigurableContentBlocks::Path.new("lead_organisation_ids"))
   end
 
   def worldwide_organisation_association_required?
-    required_field_paths.include?(ConfigurableContentBlocks::Path.new("worldwide_organisation_document_ids"))
+    current_tab_context_includes_field?("worldwide_organisation_document_ids") &&
+      required_field_paths.include?(ConfigurableContentBlocks::Path.new("worldwide_organisation_document_ids"))
   end
 
   def world_location_association_required?
-    required_field_paths.include?(ConfigurableContentBlocks::Path.new("world_location_ids"))
+    current_tab_context_includes_field?("world_location_ids") &&
+      required_field_paths.include?(ConfigurableContentBlocks::Path.new("world_location_ids"))
   end
 
   def is_in_valid_state_for_type_conversion?
@@ -187,4 +190,15 @@ def required_field_paths
   def string_for_slug
     title if primary_locale.to_sym == translation.locale
   end
+
+  def current_tab_context_includes_field?(attribute_name)
+    return true if current_tab_context.blank? # assume we are checking against the entire edition
+
+    form = type_instance.form(current_tab_context)
+    return true if form.nil?
+
+    (form["fields"] || {}).any? do |_key, field|
+      Array(field["attribute_path"]).include?(attribute_name)
+    end
+  end
 end

app/views/admin/editions/show/_main.html.erb

@@ -34,8 +34,7 @@
   </section>
 
   <%= render partial: "admin/editions/show/main_notices", locals: { edition: @edition } %>
-
-  <%= render Admin::Editions::Show::PreviewComponent.new(edition: @edition) %>
+  <%= render Admin::Editions::Show::PreviewComponent.new(edition: @edition, invalid_tab_forms: @invalid_tab_forms) %>
 
   <% if @edition.change_note_required? %>
     <section class="app-view-summary__section">

app/views/admin/editions/show/_sidebar_notices.html.erb

@@ -7,6 +7,17 @@
 
 <div class="app-view-summary__sidebar-notices">
   <% unless @edition.valid?(:publish) %>
+    <% invalid_items = if @edition.is_a?(StandardEdition) && @invalid_tab_forms&.any?
+      @invalid_tab_forms.map do |tab|
+        link_to(
+          "#{tab[:label]} tab is invalid",
+          edit_admin_standard_edition_path(@edition, current_tab: tab[:tab_key]),
+          class: "govuk-link",
+        )
+      end
+    else
+      @edition.errors.map(&:full_message)
+    end %>
     <%= render "components/inset_prompt", {
       data_attributes: {
         module: "ga4-auto-tracker",
@@ -18,7 +29,7 @@
       title: "This edition is invalid",
       description: render("govuk_publishing_components/components/list", {
         visible_counters: true,
-        items:  @edition.errors.map(&:full_message),
+        items: invalid_items,
       }),
       error: true,
     } %>