Display only publications in in_pre_publication_state in EditionFilter of StatisticsAnnouncementPublicationController [WHIT-3132]#11474
Open
patrickpatrickpatrick wants to merge 1 commit into
Conversation
patrickpatrickpatrick
changed the title
without_not_published in filter of StatisticsAnnouncement [WHIT-3132]
patrickpatrickpatrick
force-pushed
the
display-only-draft-publications-for-announcments
branch
2 times, most recently
from
abe274d to
4207deb
Compare
patrickpatrickpatrick
changed the title
without_not_published in filter of StatisticsAnnouncement [WHIT-3132]without_draft in filter of StatisticsAnnouncement [WHIT-3132]
patrickpatrickpatrick
changed the title
without_draft in filter of StatisticsAnnouncement [WHIT-3132]without_draft in filter of StatisticsAnnouncement [WHIT-3132]
patrickpatrickpatrick
force-pushed
the
display-only-draft-publications-for-announcments
branch
2 times, most recently
from
b8bc74c to
d480f95
Compare
patrickpatrickpatrick
changed the title
without_draft in filter of StatisticsAnnouncement [WHIT-3132]without_draft in EditionFilter of StatisticsAnnouncementPublicationController` [WHIT-3132]
Contributor
There was a problem hiding this comment.
Could you not append .in_pre_publication_state here rather than add a new edition filter option?
Contributor
There was a problem hiding this comment.
I could be confused, but I think might be the other way around from what is in the ticket.
https://gov-uk.atlassian.net/browse/WHIT-3132 says that you should only be able to link the statistics announcements to a draft, since when that draft is published, the statistics announcement redirects to the published thing and not the other way around.
patrickpatrickpatrick
force-pushed
the
display-only-draft-publications-for-announcments
branch
from
d480f95 to
2cfd443
Compare
patrickpatrickpatrick
changed the title
without_draft in EditionFilter of StatisticsAnnouncementPublicationController` [WHIT-3132]in_pre_publication_state in EditionFilter of StatisticsAnnouncementPublicationController [WHIT-3132]
patrickpatrickpatrick
force-pushed
the
display-only-draft-publications-for-announcments
branch
2 times, most recently
from
4ec5b38 to
c397b37
Compare
Only present to the user documents with an unpublished edition in the results page for filtering documents to connect to a StatisticsAnnouncement. This prevents a user connecting a published edition which had unintended consequences.
patrickpatrickpatrick
force-pushed
the
display-only-draft-publications-for-announcments
branch
from
c397b37 to
4520a0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
StatisticsAnnouncementPublicationControllerWhy
Only present to the user unpublished editions in the results page for filtering documents to connect to a
StatisticsAnnouncement. This prevents a user connecting a published edition which had unintended consequences.This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.