[WHIT-3439] Remove unused Whitehall healthcheck endpoints#11477
Merged
Conversation
…led_editions endpoints These were consumed by Icinga and have been superseded by the Prometheus gauges whitehall_scheduled_publishing_overdue and whitehall_unenqueued_scheduled_publications, populated by lib/collectors/scheduled_publishing_collector.rb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two orphaned HTTP healthcheck endpoints from Whitehall:
GET /healthcheck/overdueGET /healthcheck/unenqueued_scheduled_editionsThese were originally consumed by Icinga and have been superseded by the Prometheus gauges
whitehall_scheduled_publishing_overdueandwhitehall_unenqueued_scheduled_publications, populated bylib/collectors/scheduled_publishing_collector.rb. PagerDuty now alerts off those gauges via theseverity: pageAlertmanager match.The Kubernetes liveness/readiness probes (
GET /healthcheck/live,GET /healthcheck/ready) are unchanged.External access to
/healthcheck/*was already blocked at the nginx layer in alphagov/govuk-helm-charts#4278 and #4280, and Logit data showed no legitimate caller was using these endpoints.Jira
Test plan
rails routes | grep healthcheckshows only/healthcheck/liveand/healthcheck/ready