Add Welsh translation for non-ministerial department pages#11483
Open
jamiestamp wants to merge 2 commits into
Open
Add Welsh translation for non-ministerial department pages#11483jamiestamp wants to merge 2 commits into
jamiestamp wants to merge 2 commits into
Conversation
English behaviour is unchanged. Templates receive both %{relationship}
(article-prefixed) and %{type_name} (bare) so locale-specific grammar
can be decided in YAML rather than branching on locale in Ruby.
Welsh organisation pages of non-ministerial departments now render "Adran anweinidogol yw'r X" instead of falling back to English. Other organisation types continue to render in English until their sentence templates are confirmed by a translator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lays the foundation on which to translate organisations and their relationships to Welsh. The text had been all hard-coded and built dynamically before. Initially we just have the single org and relationship translated.