WIP: Add an "Approved" state to Whitehall#11559
Draft
ChrisBAshton wants to merge 1 commit into
Draft
Conversation
It's always been confusing that one can submit an edition for 2i, and that it can be rejected, but that there is no concept of 'approving' it. A submitted edition can be immediately published by anyone else, provided they weren't the person who submitted it for 2i. The sidebar options are "Publish" or "Reject". The proposal here is that the options instead are "Approve" or "Reject". On approval, the options would then become "Publish" and "Dismiss approval" (much like it's possible to dismiss a PR review in GitHub). We wouldn't want a draft to get 'stuck' in an approved state with no means of requesting 2i again even after a major draft edit. Dismissing the approval would put it back into "draft" state and the publisher could then go through the normal 2i flow again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's always been confusing that one can submit an edition for 2i, and that it can be rejected, but that there is no concept of 'approving' it. A submitted edition can be immediately published by anyone else, provided they weren't the person who submitted it for 2i. The sidebar options are "Publish" or "Reject". The proposal here is that the options instead are "Approve" or "Reject".
On approval, the options would then become "Publish" and "Dismiss approval" (much like it's possible to dismiss a PR review in GitHub). We wouldn't want a draft to get 'stuck' in an approved state with no means of requesting 2i again even after a major draft edit. Dismissing the approval would put it back into "draft" state and the publisher could then go through the normal 2i flow again.
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.