Windows Build Fix #129
Closed
Windows Build Fix #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cursor hit-test setting was moved from Window.cursor.hit_test to a separate CursorOptions component in Bevy 0.14. Update the toggle_window_passthrough system to query and modify CursorOptions instead. Closes the compile error on Bevy 0.17 🎉
The cursor hit-test setting was moved from Window.cursor.hit_test to a separate CursorOptions component in Bevy 0.14. Update the toggle_window_passthrough system to query and modify CursorOptions instead. Closes the compile error on Bevy 0.17 🎉
alphastrata
requested changes
Nov 21, 2025
Owner
alphastrata
left a comment
alphastrata
left a comment
There was a problem hiding this comment.
Cool cool.
Thanks for the PR can you split it up into two please? one for the pass-through and one for the drag-n-drop png support.
(Just makes it easier from a maintainer POV to see what went in where..)
|
|
||
| fn main() { | ||
| let args: Vec<String> = env::args().collect(); | ||
Owner
There was a problem hiding this comment.
which version of rustfmt are you using?
| pub fn toggle_window_passthrough( | ||
| keyboard_input: Res<ButtonInput<KeyCode>>, | ||
| mut windows: Query<&mut Window>, | ||
| mut windows: Query<(&mut Window, &mut CursorOptions)>, // Query both! |
Owner
|
p.s @Kyran-art great catch on the png support -- I'd dropped the ball there for drag-n-drop... my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toggle mouse passthrough on Bevy 0.14+ (use CursorOptions component instead of window.cursor)
The second commit was me cleaning up some personal residue. Should be clean now.