Fix windows build #130
Merged
Fix windows build #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toggle mouse passthrough now uses CursorOptions component instead of window.cursor.
fix: `get_single_mut()` to `single_mut()`
Changed test `UserSession` window_dims from float to u32
alphastrata
reviewed
Nov 21, 2025
src/utils.rs
Outdated
| pub fn toggle_window_passthrough( | ||
| keyboard_input: Res<ButtonInput<KeyCode>>, | ||
| mut windows: Query<&mut Window>, | ||
| mut windows: Query<(&mut Window, &mut CursorOptions)>, // Query both! |
alphastrata
reviewed
Nov 21, 2025
src/utils.rs
Outdated
| cursor_options.hit_test = !cursor_options.hit_test; | ||
|
|
||
| info!( | ||
| "PASSTHROUGH TOGGLED → hit_test: {} | decorations: {:?}", |
Owner
There was a problem hiding this comment.
→ ? probs better to use : as it's more widely supported, these extended glyph/chars etc are not supported by all fonts.
alphastrata
requested changes
Nov 21, 2025
Owner
alphastrata
left a comment
alphastrata
left a comment
There was a problem hiding this comment.
Looks great, just the same comment and → ? that need removing
replace :? with :
alphastrata
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will now run.
The drag n drop fixes from my previous PR were unintentionally included and not tested.