Fix persisted single-value stores#4859
Open
joshhanley wants to merge 1 commit into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scenario
When
Alpine.$persist()is used as the direct value of a single-value store, the store initially renders[object Object]instead of its persisted value.The Problem
Alpine.$persist()wraps the initial value until Alpine sets up persistence.Alpine currently initialises wrapped values found inside a store object, but skips the wrapper when it is the entire store.
The wrapper is therefore exposed through
$store.language, causing it to display[object Object]. Changes to the store are also not saved.The Solution
The solution is to check whether the store value itself needs to be initialised.
When it does, Alpine replaces it with the real persisted value and watches that store for future changes. Object stores continue using the existing logic for persisted properties.
Fixes #4855