-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Moved PurgeCSS to Jekyll Build #3267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for relaxed-lollipop-b6bc17 failed. Why did it fail? →
|
|
@george-gca here's another one! |
|
Will definitely took a look at this. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@MUmarShahbaz sorry for the (VERY LONG) delay on checking this. Question: we have in our purge css config this line: This is used to avoid purging inline css, if I am not wrong, for htmls generated by jupyter notebooks. How this is being handled in your case? Does it displays correctly the notebook from the sample, both light and dark modes? |
|
@george-gca that's what I thought earlier too. For some reason, it has just a ghost presence. It doesn't do anything. You can see from the huge difference in size when running my plugin as compared to the current setup. Right now, I'm trying to mimic the customization options through manual logic in ruby and there are some kinks, I admit, but overall it's working. I spent hours, using your repo for reference, to add purgecss to mine. After failing many times, it turned out that your's isn't working either. |
|
As for the skipped content blobs, it basically never touches them. Underneath, it uses logic to manually single out and purge each file one at a time. You can see them in the logs as it goes them all. |
Fixes #3266
Purpose
Issue: PurgeCSS was not working with
purgecss.config.js, only with inline configSolution: Created a Ruby Gem to run PurgeCSS using Configuration defined inside
_config.yml.Now, all assets optimization configs (minifier, terser, purgecss) are together allowing ease of use.
Example of use
Before
After
New Logs - Helps in debugging