[MINOR] Update bib_search.liquid to use input type search
#3329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the input type from text to search to add an X to clear the search box from text.
✅ Deploy Preview for relaxed-lollipop-b6bc17 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cakiki
changed the title
search
Collaborator
|
The only issue is now with the color of the X, which is barely appearing on dark mode. Can you fix that @cakiki? |
Author
|
@george-gca Sorry for the ping, but I wanted to make sure I was looking at the correct way to do this. Is this what I should be using to style the Found it here: https://stackoverflow.com/questions/47041672/change-the-color-of-the-clear-button-x-in-input-type-search |
Collaborator
|
@cakiki sorry for the late reply. Not really sure, but it appears that this might be it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the input type from text to search to add an X to clear the search box from text.
Fixes #3328
Sorry if I'm missing something obvious with this. I don't have much webdev experience.