docs update - #295
Conversation
|
let me know when this is ready and i'll merge. i just figured out the read the docs integration issue i think so should be able to release when you're ready. and yeah, you'll find more and we'll release again. i just need to have the process working. it's been awhile... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v0.8.0 #295 +/- ##
===============================================
Coverage 99.90% 99.90%
===============================================
Files 35 35
Lines 2101 2101
Branches 294 294
===============================================
Hits 2099 2099
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3722be5 to
096348a
Compare
|
LGTM. Issues will come up (how it goes...) but those can be addresses as they appear rather than holding indefinitely. |
|
yeah, part of releasing quick here is just to find and work out the bugs in that process... so next time is easier again. |
|
i'm not necessarily against it, but what is the reason for dropping pyside2 at this point? having at least one version that works on both can be nice for any of the (very few i suspect) other folks that might be using this. |
I thought (incorrectly) that PySide 2 supported only up to 3.9. I'll update this, don't see any reason to keep it out |
|
ah yeah, all those ragged matrix conditions... a pain. |
I'll follow your suggestions here. I'm not against developing a workaround for 5.15.2.1, but at the same time deprecating (or even just leaving it claimed untested) may be easier. |
|
i'll take a look in the morning, thanks |
|
ok, i missed the morning. and actually i'm starting with a question i guess. was there a failure you were seeing that lead to removing it? or do we just need to remove the removal notices from this pr |
|
I guess I'm a bit confused here, I though 5.15.2.1 was the only Pyside 2 version compatible with 3.10 and currently: pyside2 ~= 5.15, != 5.15.2, != 5.15.2.1 |
|
Also, the matrix currently excludes Pyside 2. I didn't see any errors, but it's also not getting tested. Ha, for fun I reenabled |
|
So, |
|
thanks. i think its fine to leave it untested for now. i do tend to keep support around too long (pytest-twisted still runs on py2...) and it would be good to consider removal. we are indeed down to a very small potential support area there. |
|
Seems ready to merge to me Codecov failing from MacOS runners busy. Should pass once they run. |
No description provided.