feat(cosmos): replace JSON tx encoding with SDK protobuf via TxConfig and SIGN_MODE_DIRECT#18
Merged
Merged
Conversation
… and SIGN_MODE_DIRECT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
pkg/network/cosmos/txbuilder.go: Refactored BuildTx and SignTx to use SDK's TxBuilderpkg/network/cosmos/build_test.go: Added txConfig to test TxBuilder instancespkg/network/cosmos/sign_test.go: Updated tests to use real protobuf-encoded bytesinternal/daemon/controller/transaction.go: Added GasLimit with default 200000internal/daemon/types/transaction.go: Added GasLimit field to TransactionSpecinternal/daemon/server/devnet_service.go: Added RunHooks methodtypes/ports.go: Added LabelFilter to DevnetFilterinternal/application/devnet/export.go: Fixed checksum to use genesis file hashcmd/devnet-builder/commands/manage/deploy.go: Added port conflict detectionTest plan