fix(transaction): resolve three critical issues in transaction lifecycle#19
Merged
Merged
Conversation
…ropagation bugs Fixed three critical issues in transaction processing: 1. EVM signature encoding - signatures now properly embedded in tx bytes 2. Concurrency safety - added mutex protection and context deadline checks 3. Memo field propagation - memo now flows from API to builder All tests pass with race detector enabled.
qj0r9j0vc2
force-pushed
the
fix/tx-signature-concurrency-memo
branch
from
61cacd9 to
e09b713
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three critical bugs in transaction processing:
Changes
EVM Signature Fix (
pkg/network/evm/txbuilder.go)types.SignTx()to properly embed signature into transactionConcurrency Safety (
internal/daemon/controller/transaction.go)sync.RWMutexfor thread-safe cache operationsMemo Propagation (types, server, controller)
Memofield toTransactionSpecTesting
All tests pass with race detector:
go test -race ./internal/daemon/controller/