feat: make video recording optional via env var and capability (fixes #339)#348
Draft
devimano2011 wants to merge 2 commits into
Draft
feat: make video recording optional via env var and capability (fixes #339)#348devimano2011 wants to merge 2 commits into
devimano2011 wants to merge 2 commits into
Conversation
Removed 'profileDir' from the interface and adjusted video recording options in the context creation.
…lumnium-hq#339) Added 'profileDir' and 'recordVideos' properties to the options interface.
p0deje
requested changes
May 14, 2026
Contributor
p0deje
left a comment
p0deje
left a comment
There was a problem hiding this comment.
This doesn't implement the necessary fix - videos are now not recorded at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Thank you for your contribution to Alumnium!
Please fill out this template to help us understand and review your PR efficiently.
Summary
What is this pull request about?
Provide a brief description of what the PR does, the problem it solves, and any context around the implementation.
Motivation
Why is this change being made?
Describe the use case, problem, or opportunity that this PR addresses.
Explain how this change contributes to the project's goals or improves functionality.
Related Issue(s)
If this PR fixes or is related to an open issue, link it here.
Example: Closes #123
Closes #
Type of Change
Mark the relevant options.
Code or UI Demos (if applicable)
Add screenshots, logs, terminal output, or code snippets that help reviewers understand the change.
Useful especially for UI changes or error fixes.
Checklist
Please verify the following before submitting:
Additional Notes
Anything else the reviewer should be aware of?
For example: limitations, discussions to follow up on, or next steps.