Skip to content

Update data (tsup build) #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

Update data (tsup build) #283

merged 3 commits into from
Apr 22, 2025

Conversation

MattIPv4
Copy link
Member

Copy link

cloudflare-workers-and-pages bot commented Apr 14, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
extension-preview 689d6dd Visit preview Apr 21 2025, 08:28 PM

@MattIPv4 MattIPv4 force-pushed the MattIPv4/data-tsup branch from 08ab445 to f36584d Compare April 14, 2025 17:47
@MattIPv4 MattIPv4 force-pushed the MattIPv4/data-tsup branch 3 times, most recently from 00e1bfd to 8ab6c4f Compare April 14, 2025 21:30
@MattIPv4 MattIPv4 force-pushed the MattIPv4/data-tsup branch from 9f63e68 to 689d6dd Compare April 21, 2025 20:26
@MattIPv4 MattIPv4 marked this pull request as ready for review April 21, 2025 20:30
@Copilot Copilot AI review requested due to automatic review settings April 21, 2025 20:30
@MattIPv4 MattIPv4 requested a review from a team as a code owner April 21, 2025 20:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project build configuration and data handling for the tsup build. Key changes include:

  • Removal of a dedicated ts-loader rule for @alveusgg packages from the webpack configuration.
  • An update to the ambassadors hook to extend the image schema with a new URL validation for the "src" property.

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
webpack.config.ts Removed the custom TypeScript rule for packages under "@alveusgg".
src/hooks/useAmbassadors.tsx Updated the image schema to extend the ambassador schema with a "src" URL field.
Files not reviewed (2)
  • package.json: Language not supported
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

webpack.config.ts:168

  • Review the removal of the dedicated ts-loader rule for @alveusgg packages. Confirm that these packages are still transpiled as expected without this rule.
// Load typescript in @alveusgg packages

src/hooks/useAmbassadors.tsx:37

  • The updated image schema now requires a 'src' property with URL validation; ensure that the API response includes this field or mark it as optional if necessary.
image: ambassadorImageSchema.extend({

Copy link
Member

@pjeweb pjeweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

@MattIPv4 MattIPv4 merged commit 5b17bde into main Apr 22, 2025
7 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/data-tsup branch April 22, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants