Add light box rings to buttons + cards #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the visual style of UI components by introducing a new Ring component that provides a light box ring effect on buttons, cards, and ambassador components.
- Ambassadors.tsx: Replaces conditional outline styling with an "active" prop.
- Buttons.tsx and AmbassadorButton.tsx: Remove outline classes and integrate the new Ring component for active state indication.
- Card.tsx and AmbassadorCard.tsx: Incorporate the Ring component to enhance visual emphasis.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/overlay/components/overlay/Ambassadors.tsx | Updated active state handling using the new active prop instead of conditional outline styling. |
| src/pages/overlay/components/Buttons.tsx | Removed outline classes and added Ring component to visually represent active state. |
| src/components/Ring.tsx | Introduced a new Ring component that encapsulates the light box ring effect logic. |
| src/components/Card.tsx | Integrated the Ring component to provide a visual light ring effect on cards. |
| src/components/AmbassadorCard.tsx | Added the Ring component within the ambassador card layout. |
| src/components/AmbassadorButton.tsx | Updated to pass active prop and include the Ring component for consistent visual feedback. |
Comments suppressed due to low confidence (1)
src/pages/overlay/components/overlay/Ambassadors.tsx:148
- Removing the conditional outline styling in favor of passing an 'active' prop requires confirmation that the receiving component properly applies the intended visual feedback when active. Please ensure that the component now using the 'active' prop handles styling consistently.
className="w-full"
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
extension-preview | b34cf16 | Visit preview | Apr 18 2025, 03:04 AM |
MattIPv4
force-pushed
the
MattIPv4/box-rings
branch
from
b9132f8 to
b34cf16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a similar visual style to what we've been doing on the site recently, to help make the buttons/cards stand out more against the stream content.