Skip to content

⚡ Bolt: [performance improvement] Optimize updateStatistics array iterations #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alvin000009238 wants to merge 1 commit into from
Closed

⚡ Bolt: [performance improvement] Optimize updateStatistics array iterations #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions frontend/dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,19 +130,21 @@ function updateStatistics(subjects) {
return;
}

const scores = subjects.map(subject => subject.scoreValue);
const highest = Math.max(...scores);

// 計算加權平均
// 計算加權平均與最高分
let highest = -Infinity;
let totalWeightedScore = 0;
let totalWeight = 0;

subjects.forEach(subject => {
for (let i = 0; i < subjects.length; i++) {
const subject = subjects[i];
const score = subject.scoreValue;

if (score > highest) highest = score;

const weight = getSubjectWeight(subject.SubjectName);
totalWeightedScore += score * weight;
totalWeight += weight;
});
}
Comment on lines +138 to +147

@gemini-code-assist gemini-code-assist Bot Apr 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the manual for loop is efficient, using a for...of loop is more idiomatic in modern JavaScript and improves readability by removing the need for manual index management. Modern engines optimize for...of to perform nearly identically to a standard for loop for array iterations.

Additionally, consider using highest = Math.max(highest, score) to maintain behavioral parity with the original implementation regarding NaN values. The current if (score > highest) logic will ignore NaN scores, whereas the original Math.max(...scores) would result in NaN if any score was invalid. If all scores happen to be invalid, the current code would incorrectly display -Infinity in the UI.

    for (const subject of subjects) {
        const score = subject.scoreValue;

        highest = Math.max(highest, score);

        const weight = getSubjectWeight(subject.SubjectName);
        totalWeightedScore += score * weight;
        totalWeight += weight;
    }


const weightedAvg = totalWeight > 0 ? totalWeightedScore / totalWeight : 0;

Expand Down
Loading