Skip to content

🧪 [Testing Improvement] Add error state test for loadYears in ScheduleViewModel #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alvin000009238 wants to merge 1 commit into from
Closed

🧪 [Testing Improvement] Add error state test for loadYears in ScheduleViewModel #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions android/app/src/test/java/com/clhs/score/viewmodel/ScheduleViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import kotlinx.coroutines.test.setMain
import org.junit.After
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Assert.assertTrue
import org.junit.Before
import org.junit.Test

Expand Down Expand Up @@ -74,6 +75,21 @@ class ScheduleViewModelTest {
assertEquals("202", viewModel.uiState.value.selectedClassValue)
}

@Test
fun loadYearsErrorUpdatesState() = runTest(dispatcher) {
val repository = ControllableScheduleRepository()
val viewModel = ScheduleViewModel(repository)
runCurrent()

repository.yearsDeferred.completeExceptionally(RuntimeException("Network error"))
runCurrent()

val state = viewModel.uiState.value
assertFalse(state.isLoading)
assertTrue(state.isError)
assertEquals("Network error", state.errorMessage)
Comment on lines +88 to +90

@gemini-code-assist gemini-code-assist Bot Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It is highly recommended to also assert that isInitialLoading is set to false. In ScheduleViewModel, isInitialLoading is updated to false before loadYears() is called. Verifying this in the error state test ensures that the UI doesn't get stuck in an infinite full-screen loading state when an error occurs.

        assertFalse(state.isLoading)
        assertFalse(state.isInitialLoading)
        assertTrue(state.isError)
        assertEquals("Network error", state.errorMessage)

}

@Test
fun savingWidgetPreferencesLogsAnonymousAnalytics() = runTest(dispatcher) {
val repository = ControllableScheduleRepository()
Expand Down
Loading