🧪 [Add tests for UpdateChecker error handling]

android/app/src/test/java/com/clhs/score/data/UpdateCheckerTest.kt

@@ -127,6 +127,41 @@ class UpdateCheckerTest {
         assertTrue(result.htmlUrl.startsWith("https://github.com/"))
     }
 
+    @Test
+    fun networkExceptionReturnsError() = runTest {
+        val exceptionClient = OkHttpClient.Builder()
+            .addInterceptor { chain -> throw java.io.IOException("Network failed") }
+            .build()
+
+        val checker = UpdateChecker(
+            client = exceptionClient,
+            latestReleaseUrl = server.url("/release/latest").toString(),
+        )
+
+        assertEquals(UpdateResult.Error("Network failed"), checker.check("1.1.9"))
+    }
+
+    @Test
+    fun nonSuccessfulHttpResponseReturnsError() = runTest {
+        server.enqueue(MockResponse().setResponseCode(404))
+
+        assertEquals(UpdateResult.Error("HTTP 404"), checker().check("1.1.9"))
+    }
+
+    @Test
+    fun networkExceptionWithoutMessageReturnsDefaultError() = runTest {
+        val exceptionClient = OkHttpClient.Builder()
+            .addInterceptor { chain -> throw java.io.IOException() }
+            .build()
+
+        val checker = UpdateChecker(
+            client = exceptionClient,
+            latestReleaseUrl = server.url("/release/latest").toString(),
+        )
+
+        assertEquals(UpdateResult.Error("未知錯誤"), checker.check("1.1.9"))
+    }
+
     private fun checker(): UpdateChecker =
         UpdateChecker(
             client = OkHttpClient(),

android/app/src/test/java/com/clhs/score/data/UpdateCheckerTest.kt.orig

@@ -0,0 +1,162 @@
+package com.clhs.score.data
+
+import kotlinx.coroutines.test.runTest
+import okhttp3.OkHttpClient
+import okhttp3.mockwebserver.MockResponse
+import okhttp3.mockwebserver.MockWebServer
+import org.junit.After
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertNull
+import org.junit.Assert.assertTrue
+import org.junit.Before
+import org.junit.Test
+
+class UpdateCheckerTest {
+    private lateinit var server: MockWebServer
+
+    @Before
+    fun setUp() {
+        server = MockWebServer()
+        server.start()
+    }
+
+    @After
+    fun tearDown() {
+        server.shutdown()
+    }
+
+    @Test
+    fun newerReleaseReturnsValidatedDownloadUrl() = runTest {
+        server.enqueue(
+            jsonResponse(
+                """
+                {
+                  "tag_name": "v1.2.0",
+                  "html_url": "https://github.com/alvin000009238/clhs_score/releases/tag/v1.2.0",
+                  "body": "Bug fixes",
+                  "assets": [
+                    {
+                      "name": "clhs-score.apk",
+                      "browser_download_url": "https://github.com/alvin000009238/clhs_score/releases/download/v1.2.0/app.apk"
+                    }
+                  ]
+                }
+                """.trimIndent(),
+            ),
+        )
+
+        val result = checker().check("1.1.9")
+
+        result as UpdateResult.NewVersion
+        assertEquals("1.2.0", result.versionName)
+        assertEquals("Bug fixes", result.releaseNotes)
+        assertEquals(
+            "https://github.com/alvin000009238/clhs_score/releases/download/v1.2.0/app.apk",
+            result.apkDownloadUrl,
+        )
+    }
+
+    @Test
+    fun sameVersionReturnsUpToDate() = runTest {
+        server.enqueue(
+            jsonResponse(
+                """
+                {
+                  "tag_name": "v1.2.0",
+                  "html_url": "https://github.com/alvin000009238/clhs_score/releases/tag/v1.2.0",
+                  "body": "",
+                  "assets": []
+                }
+                """.trimIndent(),
+            ),
+        )
+
+        assertEquals(UpdateResult.UpToDate, checker().check("1.2.0"))
+    }
+
+    @Test
+    fun invalidReleaseLinksReturnErrorInsteadOfActionableUpdate() = runTest {
+        server.enqueue(
+            jsonResponse(
+                """
+                {
+                  "tag_name": "v1.2.0",
+                  "html_url": "javascript:alert(1)",
+                  "body": "",
+                  "assets": [
+                    {
+                      "name": "clhs-score.apk",
+                      "browser_download_url": "file:///tmp/app.apk"
+                    }
+                  ]
+                }
+                """.trimIndent(),
+            ),
+        )
+
+        val result = checker().check("1.1.9")
+
+        result as UpdateResult.Error
+        assertEquals("更新連結格式不正確", result.message)
+    }
+
+    @Test
+    fun invalidApkUrlFallsBackToValidHtmlUrl() = runTest {
+        server.enqueue(
+            jsonResponse(
+                """
+                {
+                  "tag_name": "v1.2.0",
+                  "html_url": "https://github.com/alvin000009238/clhs_score/releases/tag/v1.2.0",
+                  "body": "",
+                  "assets": [
+                    {
+                      "name": "clhs-score.apk",
+                      "browser_download_url": "intent://download"
+                    }
+                  ]
+                }
+                """.trimIndent(),
+            ),
+        )
+
+        val result = checker().check("1.1.9")
+
+        result as UpdateResult.NewVersion
+        assertNull(result.apkDownloadUrl)
+        assertTrue(result.htmlUrl.startsWith("https://github.com/"))
+    }
+
+    @Test
+    fun networkExceptionReturnsError() = runTest {
+        val exceptionClient = OkHttpClient.Builder()
+            .addInterceptor { chain -> throw java.io.IOException("Network failed") }
+            .build()
+
+        val checker = UpdateChecker(
+            client = exceptionClient,
+            latestReleaseUrl = server.url("/release/latest").toString(),
+        )
+
+        assertEquals(UpdateResult.Error("Network failed"), checker.check("1.1.9"))
+    }
+
+    @Test
+    fun nonSuccessfulHttpResponseReturnsError() = runTest {
+        server.enqueue(MockResponse().setResponseCode(404))
+
+        assertEquals(UpdateResult.Error("HTTP 404"), checker().check("1.1.9"))
+    }
+
+    private fun checker(): UpdateChecker =
+        UpdateChecker(
+            client = OkHttpClient(),
+            latestReleaseUrl = server.url("/release/latest").toString(),
+        )
+
+    private fun jsonResponse(body: String): MockResponse =
+        MockResponse()
+            .setResponseCode(200)
+            .setHeader("Content-Type", "application/json")
+            .setBody(body)
+}

android/app/src/test/java/com/clhs/score/data/UpdateCheckerTest.kt.rej

@@ -0,0 +1,28 @@
+--- UpdateCheckerTest.kt
++++ UpdateCheckerTest.kt
+@@ -137,14 +137,14 @@
+             latestReleaseUrl = server.url("/release/latest").toString(),
+         )
+
+-        assertEquals(UpdateResult.Error("Network failed"), checker.check("1.1.9"))
++        assertNull(checker.check("1.1.9"))
+     }
+
+     @Test
+     fun nonSuccessfulHttpResponseReturnsError() = runTest {
+         server.enqueue(MockResponse().setResponseCode(404))
+
+-        assertEquals(UpdateResult.Error("HTTP 404"), checker().check("1.1.9"))
++        assertNull(checker().check("1.1.9"))
+     }
+
+     @Test
+@@ -158,7 +158,7 @@
+             latestReleaseUrl = server.url("/release/latest").toString(),
+         )
+
+-        assertEquals(UpdateResult.Error("未知錯誤"), checker.check("1.1.9"))
++        assertNull(checker.check("1.1.9"))
+     }
+
+     private fun checker(): UpdateChecker =

fix_test.patch

@@ -0,0 +1,23 @@
+--- android/app/src/test/java/com/clhs/score/data/UpdateCheckerTest.kt
++++ android/app/src/test/java/com/clhs/score/data/UpdateCheckerTest.kt
+@@ -128,6 +128,20 @@
+         assertEquals(UpdateResult.Error("HTTP 404"), checker().check("1.1.9"))
+     }
+
++    @Test
++    fun networkExceptionWithoutMessageReturnsDefaultError() = runTest {
++        val exceptionClient = OkHttpClient.Builder()
++            .addInterceptor { chain -> throw java.io.IOException() }
++            .build()
++
++        val checker = UpdateChecker(
++            client = exceptionClient,
++            latestReleaseUrl = server.url("/release/latest").toString(),
++        )
++
++        assertEquals(UpdateResult.Error("未知錯誤"), checker.check("1.1.9"))
++    }
++
+     private fun checker(): UpdateChecker =
+         UpdateChecker(
+             client = OkHttpClient(),