⚡ Bolt: [performance improvement] Cache Regex in getSubjectBaseName - #195
⚡ Bolt: [performance improvement] Cache Regex in getSubjectBaseName#195alvin000009238 wants to merge 1 commit into
Conversation
Co-authored-by: alvin000009238 <107313913+alvin000009238@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes the getSubjectBaseName function in GradeModels.kt by caching the regex pattern at the file level to avoid recompilation overhead. However, a critical issue was identified where the regex pattern was incorrectly modified to match a literal dollar sign instead of the end-of-line anchor, which breaks the subject name parsing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| } | ||
|
|
||
| // Optimization: Cache Regex at file level to avoid recompilation overhead in getSubjectBaseName | ||
| private val subjectSuffixRegex = Regex("([A-Z甲乙]|I{1,3}|IV|V)\\$") |
There was a problem hiding this comment.
By changing the regex string literal to use double backslashes, the pattern now matches a literal dollar sign character instead of acting as the end-of-line anchor. This breaks the subject name parsing (e.g., '數學I' will no longer be cleaned to '數學'). Please revert it to use a single backslash escape for the dollar sign.
| private val subjectSuffixRegex = Regex("([A-Z甲乙]|I{1,3}|IV|V)\\$") | |
| private val subjectSuffixRegex = Regex("([A-Z甲乙]|I{1,3}|IV|V)\$") |
There was a problem hiding this comment.
Pull request overview
This PR aims to improve performance in the Android data model utilities by caching the regex used by getSubjectBaseName, avoiding repeated regex compilation in a frequently executed code path.
Changes:
- Introduced a file-level cached
Regex(subjectSuffixRegex) and reused it insidegetSubjectBaseName. - Added a short Bolt/Jules note documenting the optimization and benchmark result.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| android/app/src/main/java/com/clhs/score/data/GradeModels.kt | Extracts the subject-suffix regex to a file-level constant and uses it in getSubjectBaseName. |
| .jules/bolt.md | Adds an internal note documenting the regex caching optimization and the measured speedup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| // Optimization: Cache Regex at file level to avoid recompilation overhead in getSubjectBaseName | ||
| private val subjectSuffixRegex = Regex("([A-Z甲乙]|I{1,3}|IV|V)\\$") |
| return cleaned.substringBefore("-").trim().ifEmpty { cleaned } | ||
| } | ||
|
|
||
| // Optimization: Cache Regex at file level to avoid recompilation overhead in getSubjectBaseName |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 188481732f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| // Optimization: Cache Regex at file level to avoid recompilation overhead in getSubjectBaseName | ||
| private val subjectSuffixRegex = Regex("([A-Z甲乙]|I{1,3}|IV|V)\\$") |
There was a problem hiding this comment.
For subject names such as 英語文IV or 數學A, this cached pattern now contains regex \$, which matches a literal dollar sign instead of the end-of-string anchor produced by the previous Kotlin source \$ escape. As a result, getSubjectBaseName no longer strips normal suffixes, so the subject trend screen/chart stops grouping variants under the same base name and assigns them separate colors/selection groups.
Useful? React with 👍 / 👎.
💡 What: Extracted the Regex pattern
([A-Z甲乙]|I{1,3}|IV|V)\$used ingetSubjectBaseNameto a file-level private constant (subjectSuffixRegex).🎯 Why: The
getSubjectBaseNamefunction is called frequently, particularly when mapping over lists of subjects. In its previous form, a newRegexobject was compiled on every invocation, causing unnecessary overhead. Reusing a single cached Regex avoids this.📊 Impact: Reduces CPU load and garbage collection pressure when processing large grade reports.
🔬 Measurement:
A focused JMH-style benchmark simulating 100,000 iterations over 8 common subject names showed a significant speedup:
PR created automatically by Jules for task 10636107262347189905 started by @alvin000009238