🧹 [Extract formatter methods] Extract string and number formatter methods to FormatUtils.kt - #204
🧹 [Extract formatter methods] Extract string and number formatter methods to FormatUtils.kt#204alvin000009238 wants to merge 1 commit into
Conversation
…hods to FormatUtils.kt 🎯 **What** Extracted duplicate formatters (`canonicalNumberValue`, `canonicalDisplayValue`, `formatScore`) out into a dedicated `FormatUtils.kt` class and removed them from their original, duplicated placements in `GradeReportDiffer.kt` and `GradeExporter.kt`. 💡 **Why** This makes the code more DRY (Don't Repeat Yourself), improving maintainability by consolidating these formatting utilities in one location. This means any bugs related to them can be fixed in one place. ✅ **Verification** - I ran the full test suite using `./gradlew testDebugUnitTest` and all tasks passed successfully. - Verified that all the duplicate and hardcoded components have been appropriately migrated. ✨ **Result** Reduced duplicated methods by extracting them, making the core more robust and consistent across the application. Co-authored-by: alvin000009238 <107313913+alvin000009238@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors formatting utility functions by extracting them from GradeExporter.kt and GradeReportDiffer.kt into a new shared file FormatUtils.kt. The feedback points out that Double.formatScore() uses the system's default locale, which can lead to locale-dependent decimal separators (like commas) and break CSV generation. It is recommended to use Locale.US to ensure consistent formatting.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| fun Double.formatScore(): String { | ||
| return if (this == kotlin.math.floor(this) && !this.isInfinite()) { | ||
| this.toInt().toString() | ||
| } else { | ||
| "%.1f".format(this) | ||
| } | ||
| } |
There was a problem hiding this comment.
Using "%.1f".format(this) uses the system's default locale, which can lead to locale-dependent decimal separators (e.g., , instead of .) depending on the user's device settings. Since this formatted score is used in CSV generation, using a comma as a decimal separator can cause parsing issues or inconsistency in the exported CSV.\n\nAdditionally, calling this.toInt().toString() can cause integer overflow if the value exceeds Int.MAX_VALUE (though unlikely for standard scores, it is safer to avoid).\n\nUsing String.format(Locale.US, ...) resolves both issues consistently with canonicalNumberValue.
fun Double.formatScore(): String {\n return if (this == kotlin.math.floor(this) && !this.isInfinite()) {\n String.format(Locale.US, \"%.0f\", this)\n } else {\n String.format(Locale.US, \"%.1f\", this)\n }\n}
🎯 What
Extracted duplicate formatters (
canonicalNumberValue,canonicalDisplayValue,formatScore) out into a dedicatedFormatUtils.ktclass and removed them from their original, duplicated placements inGradeReportDiffer.ktandGradeExporter.kt.💡 Why
This makes the code more DRY (Don't Repeat Yourself), improving maintainability by consolidating these formatting utilities in one location. This means any bugs related to them can be fixed in one place.
✅ Verification
./gradlew testDebugUnitTestand all tasks passed successfully.✨ Result
Reduced duplicated methods by extracting them, making the core more robust and consistent across the application.
PR created automatically by Jules for task 6705107388328619534 started by @alvin000009238