Skip to content

🎨 Palette: Add global focus-visible styles #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alvin000009238 wants to merge 1 commit into from
Closed

🎨 Palette: Add global focus-visible styles #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions frontend/styles/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,12 @@ body {



/* Focus-visible for accessibility */
:focus-visible {

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because base.css is imported near the top of frontend/style.css (before modal.css, dashboard.css, etc.), later component styles can override this global :focus-visible rule. For example, frontend/styles/modal.css sets .tooltip-icon { outline: none; }, which will prevent this focus indicator from appearing unless this rule comes later in the cascade or has higher specificity. Consider moving the global focus-visible rule to a later-imported stylesheet (e.g., utilities.css) or adjusting the selector/specificity so it reliably applies app-wide.

Suggested change
:focus-visible {
:root :focus-visible {

Copilot uses AI. Check for mistakes.
outline: 2px solid var(--color-primary);
outline-offset: 2px;
Comment on lines +128 to +130

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting in this new block doesn’t match the existing style in base.css, which uses blank lines between selectors and between declarations. Aligning the spacing/indentation here will keep the stylesheet consistent and easier to scan.

Suggested change
:focus-visible {
outline: 2px solid var(--color-primary);
outline-offset: 2px;
:focus-visible {
outline: 2px solid var(--color-primary);
outline-offset: 2px;

Copilot uses AI. Check for mistakes.
}
Comment on lines +128 to +131

@gemini-code-assist gemini-code-assist Bot Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The design system already defines a --color-focus-ring token in tokens.css (lines 86 and 139). To maintain consistency and ensure that focus styles are managed through established design tokens, consider using var(--color-focus-ring) instead of var(--color-primary). If the current value of --color-focus-ring is too subtle, it should be updated in the tokens file to match the desired prominence. Additionally, be aware that a positive outline-offset can cause the focus indicator to be clipped in containers with overflow: hidden; ensure that parent containers have sufficient padding or consider a smaller offset for the global default.

Suggested change
:focus-visible {
outline: 2px solid var(--color-primary);
outline-offset: 2px;
}
:focus-visible {
outline: 2px solid var(--color-focus-ring);
outline-offset: 2px;
}


/* ???? Container ?????????????????????????????????????????????????????? */

.container {
Expand Down
Loading