Skip to content

Saner default saturation and sharpening for color correction #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

g0vman
Copy link
Contributor

@g0vman g0vman commented Mar 28, 2025

  • Removed the pointless default saturation boost of 0.5 when enabling color correction.

  • Also reduced the default sharpening value from 0.5 to 0.25, which provides a more visually natural result by minimizing haloing/ringing artifacts. The current sharpening method remains rudimentary, and higher values quickly turn into an eye sore.

- Removed the pointless default saturation boost of 0.5 when enabling color correction.

- Also reduced the default sharpening value from 0.5 to 0.25, which provides a more visually natural result by minimizing haloing/ringing artifacts. The current sharpening method remains rudimentary, and higher values quickly turn into an eye sore.
Copy link
Member

@zmerp zmerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there have been fixes to the color range/scale since we set these defaults i'm ok with these changes

@zmerp zmerp requested a review from Meister1593 March 28, 2025 22:02
@Meister1593
Copy link
Collaborator

strange... i've been playing on 1.0 sharpening for a while and didn't notice much of haloing/ringing?...

will check on those settings on pico a bit later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants