feat(launcher): ✨ Support copying session file from other installations #2828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-personified-devil
requested changes
May 19, 2025
| @@ -264,6 +280,31 @@ async fn install_server( | |||
| tar::Archive::new(&mut GzDecoder::new(&mut buffer)).unpack(&installation_dir)?; | |||
| } | |||
|
|
|||
| if let Some(session_version) = session_version { | |||
| assert!(cfg!(windows)); | |||
There was a problem hiding this comment.
I'm not a particularly big fan of this assert just floating about without context
There was a problem hiding this comment.
Yeah, first I put a comment but then I though of all the comments we left behind that are now obsolete, so I thought to have an assert sort of explain what i wanted to say with words. But yeah probably both comment and assert is best.
| is_apk_downloaded: bool, | ||
| has_session_json: bool, // Only relevent on Windows |
Comment on lines
+286
to
+287
| let installations = get_installations(); | ||
| for inst in installations { |
There was a problem hiding this comment.
Shouldn't be a separate variable
There was a problem hiding this comment.
Yeah. This time it wasn't even ChatGPT slop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is Windows-only, because on Linux the session file is written globally on ~/config.
It finds the installations with a session file and shows them in a dropdown when installing a new version. For the edge case where a session file gets deleted during the lifetime of the launcher and the corresponding version is selected, it will gracefully show an error. I don't believe we need to handle this edge case more.
This PR contains also some minor refactoring.