Skip to content

Conversation

@zmerp
Copy link
Member

@zmerp zmerp commented Oct 31, 2025

The features list is kept at a minimum because of breaking changes and merge conflicts. the rest of the features in master will be released with v21

zmerp and others added 3 commits November 1, 2025 00:56
* Android OpenXR changes

* Recommend a large boundary

* Nit

* Cargo update

* AndroidXR platform enum

* Nits

* Better Android XR platform heuristics

* format

* Revert "format"

This reverts commit e5ec6d8.

* Revert "Better Android XR platform heuristics"

This reverts commit bfe055e.

* AndroidXR -> SamsungGalaxyXR

* oops
@The-personified-devil
Copy link
Collaborator

We should also add the audio fixes I implemented in the meantime. I recall that we wanted to make a release that bundled several audio fixes, but I guess that somehow got lost in you being busy.

@The-personified-devil
Copy link
Collaborator

If it's possible I'd like these commits added, they're all primarily bugfixes so I think they belong in a patch release:
(and most of them are very small, the only big one is the cpal one and that's important)

(only maybe, since I'm not exactly sure what bugs it fixes) 1fb60d1
7757a8b
12e6589
c3ec94b
bbbe573
4f22171
(maybe, idk if the release runners still use the old version) e1d68ca
752a499
d72efca

@shinyquagsire23
Copy link
Contributor

Fwiw I noticed a UI regression where most of the textboxes that are paired with sliders no longer can be altered, it just resets to the slider value

@shinyquagsire23
Copy link
Contributor

shinyquagsire23 commented Nov 1, 2025

Also fwiw I actually do have a cherry-pickable v20.14 version of the PSVR2 changes, might be nice to get those in a release

Edit: might need to chery-pick and then squash it down but https://github.com/shinyquagsire23/ALVR/commits/v20_14_1-with-psvr2/

@zmerp
Copy link
Member Author

zmerp commented Nov 1, 2025

@shinyquagsire23

Fwiw I noticed a UI regression where most of the textboxes that are paired with sliders no longer can be altered, it just resets to the slider value

Is this on master or v20.14.1 or this PR?

@zmerp
Copy link
Member Author

zmerp commented Nov 1, 2025

@The-personified-devil

If it's possible I'd like these commits added, they're all primarily bugfixes so I think they belong in a patch release:
(and most of them are very small, the only big one is the cpal one and that's important)

(only maybe, since I'm not exactly sure what bugs it fixes) 1fb60d1
7757a8b
12e6589
c3ec94b
bbbe573
4f22171
(maybe, idk if the release runners still use the old version) e1d68ca
752a499
d72efca

All those commits sit after the protocol breaking changes. With v20.14.1 we already gave up on merging new substantial features for the v20 cycle (the mDNS protocol break was needed for VisionOS support and already made caused issues when making new v20 releases). The goal of 20.15 would only be to support the Samsung Galaxy XR, because that headset currently doesn't work with v20.14.1 at all

We are not done with v21, we still need to merge all the sockets fixes first. After we merge #2956, there will be two other socket refactor PRs, then we can start finalizing v21

People can still use the new features, but they would have to use nightly

@The-personified-devil
Copy link
Collaborator

The-personified-devil commented Nov 1, 2025

I tried and I realized some of these may be a tad-bit annoying to backport/cherry-pick and some of them aren't really necessary, but at least the audio fix does solve a pretty annoying issue.
And either we release v21 kinda soon or we should really make a release where that is solved because there are a lot of people struggling with it.
Now I cant guarantee that sloppy backports don't also cause issues but I feel we should take the bit of time and at least try to carry these commits into the release since they are bugfixes, not features:
7757a8b
12e6589
(this is also arguably a fix of regression, but it does bump the android api level) bbbe573
(depending on the release runner version this one may be very necessary) e1d68ca
752a499

The other commits except the pipewire one I think are worth trying to bring over since they add up to like 90 lines of changes in total (and they're also bugfixes), but the ones I picked are very important imo. Especially the audio one actually hinders people from using alvr and I think it's only to be attributed to an accident that we haven't actually released a fix even tho we fixed it.

And only one of those comes actually close to touching connection/protocol stuff and that's the audio fix, which is imo the most important one of all. And sadly those also intermangle with the pipewire stuff. But what I can try to do is to cherry-pick the subcommits that make up that pr instead so that I avoid more conflicts

I'll also cherry-pick/rebase them for you if you want, since some do require a bit of adjusting to fit properly.

@shinyquagsire23
Copy link
Contributor

@shinyquagsire23

Fwiw I noticed a UI regression where most of the textboxes that are paired with sliders no longer can be altered, it just resets to the slider value

Is this on master or v20.14.1 or this PR?

master, so it's possible it's from the cargo.lock deal from the Galaxy XR, or something else

@zmerp
Copy link
Member Author

zmerp commented Nov 1, 2025

@The-personified-devil I think you can help a bit here. My time is limited, like anyone here, and I wanted to use it to work on the PRs that get us closer to the actual v21 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants