fix: pass generator param to download_pdf#227
Merged
Conversation
Member
Author
|
@Mergifyio backport version-16-hotfix version-15-hotfix |
Contributor
✅ Backports have been createdDetails
|
This was referenced Feb 17, 2026
barredterra
added a commit
that referenced
this pull request
Feb 17, 2026
fix: pass generator param to download_pdf (backport #227)
barredterra
added a commit
that referenced
this pull request
Feb 17, 2026
fix: pass generator param to download_pdf (backport #227)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept the
pdf_generatorparameter introduced in frappe/frappe#31069 and pass it along.This should fix problems with using the "chrome" pdf generator along with this app.
I'm also adding type hints to increase endpoint security and satisfy the linter.