feat: implement XML attachment file naming functionality (backport #253)

[mergify]

• Added E Invoice Settings field for global autonaming pattern for XML attachements.
• Added get_xml_attachment_file_base_name function to resolve file names.
• Introduced unit tests for various naming scenarios in test_xml_attachment_naming.py.
• Updated Sales Invoice logic to utilize the new naming function for XML file attachments.
• Integrated autonaming pattern into "Download XML" button on Sales Invoice.

Ref: IBT-164
closes #245

---

This is an automatic backport of pull request #253 done by Mergify.

[mergify]

Cherry-pick of d45a1f0 has failed:

On branch mergify/bp/version-16-hotfix/pr-253
Your branch is up to date with 'origin/version-16-hotfix'.

You are currently cherry-picking commit d45a1f0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   eu_einvoice/european_e_invoice/custom/sales_invoice.py
	new file:   eu_einvoice/european_e_invoice/custom/test_sales_invoice.py
	modified:   eu_einvoice/european_e_invoice/doctype/e_invoice_settings/e_invoice_settings.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   eu_einvoice/european_e_invoice/doctype/e_invoice_settings/e_invoice_settings.json
	both modified:   eu_einvoice/locale/de.po
	both modified:   eu_einvoice/locale/main.pot

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[greptile-apps]

Greptile Summary

This backport of #253 adds configurable XML attachment file naming to the E Invoice workflow: a new auto_name_format_for_xml_file field in E Invoice Settings lets users define a naming pattern (using Frappe's naming series syntax) that replaces the hard-coded {doc.name}.xml default. However, the automated backport left unresolved git merge conflicts in three files that must be fixed before merging.

• sales_invoice.py: New get_xml_attachment_file_base_name function resolves the naming pattern via parse_naming_series, sanitizes the result with get_safe_file_name, and falls back to doc.name on failure.
• e_invoice_settings.json: Contains two unresolved conflict blocks making it invalid JSON — the doctype cannot be loaded.
• de.po / main.pot: Both locale files have multiple unresolved conflict markers that corrupt the gettext format.

Confidence Score: 2/5

Not safe to merge — three files contain raw git conflict markers that make the doctype JSON invalid and break the German locale.

The Python implementation in sales_invoice.py and the new tests are well-constructed, but the automated backport left e_invoice_settings.json as unparseable JSON (two unresolved conflict blocks) and both locale files corrupted. As long as those conflict markers remain, importing the app or running bench migrate will fail on the doctype definition, and translation loading will error for the de locale.

e_invoice_settings.json, eu_einvoice/locale/de.po, and eu_einvoice/locale/main.pot all require manual conflict resolution before this branch can be used.

Important Files Changed

Filename	Overview
eu_einvoice/european_e_invoice/custom/sales_invoice.py	Adds get_xml_attachment_file_base_name and _no_series_counter; updates download_xrechnung to pass the full doc and use the new naming logic. Python logic is sound.
eu_einvoice/european_e_invoice/custom/test_sales_invoice.py	New unit tests covering fallback, field interpolation, hash stripping, slash sanitization, and pattern resolution — comprehensive coverage of the new naming function.
eu_einvoice/european_e_invoice/doctype/e_invoice_settings/e_invoice_settings.json	Contains unresolved git merge conflict markers at two locations, making the file invalid JSON. The doctype cannot be loaded in this state.
eu_einvoice/european_e_invoice/doctype/e_invoice_settings/e_invoice_settings.py	Adds the auto_name_format_for_xml_file typed field annotation — minimal, correct change.
eu_einvoice/locale/de.po	Contains unresolved merge conflict markers at multiple locations; the gettext parser will reject this file, breaking German translations.
eu_einvoice/locale/main.pot	Contains unresolved merge conflict markers at multiple locations; invalid .pot file that will break translation tooling.

Comments Outside Diff (1)

1. eu_einvoice/locale/de.po, line 234-238 (link)

   Unresolved merge conflict markers in gettext file

   de.po and main.pot both contain unresolved <<<<<<< HEAD / ======= / >>>>>>> d45a1f0 conflict markers throughout. The gettext parser will reject these files outright, breaking translation loading for the de locale. All conflicts in both locale files must be resolved — keeping the newer line-number references and adding the new translation strings — before merging.

   

_{Reviews (1): Last reviewed commit: "feat: implement XML attachment file nami..." | Re-trigger Greptile}