Skip to content

Bugfix/mp 32 fix missing tile destroy #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Bugfix/mp 32 fix missing tile destroy #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c95963c
bugfix(#32): add-missing-destroy-tile-function
am2222 Oct 25, 2024
cd19c01
Merge remote-tracking branch 'origin/main' into bugfix/mp-32-fix-miss…
am2222 Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ type PmTilesOptions = {


type Tile = {
destroy: () => void;
setTexture(arg0: (data: any) => any, painter: any): unknown;
request: any;
aborted: any;
Expand Down Expand Up @@ -286,7 +287,7 @@ export class PmTilesSource extends VectorTileSourceImpl {
getExtent(): mapboxgl.LngLatBoundsLike {
if (!this.header) return [[-180, -90], [180, 90]]

const { minZoom, maxZoom, minLon, minLat, maxLon, maxLat, centerZoom, centerLon, centerLat } = this.header
const { minLon, minLat, maxLon, maxLat } = this.header

return [minLon, minLat, maxLon, maxLat]
}
Expand All @@ -295,6 +296,13 @@ export class PmTilesSource extends VectorTileSourceImpl {
return !this.tileBounds || this.tileBounds.contains(tileID.canonical);
}

fixTile(tile:Tile){
if(!tile.destroy){
tile.destroy=()=>{

}
}
}
async load(callback?: Callback<void>) {
this._loaded = false;
this.fire(new Event("dataloading", { dataType: "source" }));
Expand Down Expand Up @@ -450,6 +458,7 @@ export class PmTilesSource extends VectorTileSourceImpl {
);
};

this.fixTile(tile)
if (!tile.actor || tile.state === "expired") {
tile.actor = this._tileWorkers[url] = this._tileWorkers[url] || this.dispatcher.getActor();

Expand Down Expand Up @@ -505,7 +514,7 @@ export class PmTilesSource extends VectorTileSourceImpl {
tile.tileID.canonical.url(this.tiles, this.scheme)
);
const request = this.map?._requestManager.transformRequest(url, "Tile");

this.fixTile(tile)
const controller = new AbortController();
tile.request = { cancel: () => controller.abort() };
this._protocol.tile(request, controller).then(done.bind(this))
Expand Down
Loading