Filter style fixes #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 14a7d27.
…/ag-grid-table-plugin
* Theme consolidation commit 1 * Components & Renderers styles * Table styles consolidation * Delete hook
* Theme consolidation commit 1 * Components & Renderers styles * Table styles consolidation * Delete hook * Styles * Feature flag
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const paragraphConfig = { rows: 1, width: 150 }; | ||
|
|
||
| const AnchorLink: FC<LinkProps> = ({ to, children }) => ( | ||
| <a href={to}>{children}</a> |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 months ago
To fix the issue, we need to ensure that the url value passed to the to prop of the AnchorLink component is properly sanitized or escaped to prevent XSS vulnerabilities. The best approach is to use a utility function to validate and sanitize the url before it is used. This function should ensure that the url is a valid and safe URL.
- Add a utility function,
sanitizeUrl, to validate and sanitize theurlvalue. This function can use theURLconstructor to parse and validate the URL. - Update the
AnchorLinkcomponent to sanitize thetoprop before using it in thehrefattribute. - Ensure that all instances where
urlis passed toAnchorLinkor similar components are sanitized.
Suggested changeset
2
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx
| @@ -136,4 +136,14 @@ | ||
|
|
||
| const sanitizeUrl = (url: string): string => { | ||
| try { | ||
| const parsedUrl = new URL(url, window.location.origin); | ||
| return parsedUrl.href; | ||
| } catch (e) { | ||
| console.error('Invalid URL:', url); | ||
| return '#'; | ||
| } | ||
| }; | ||
|
|
||
| const AnchorLink: FC<LinkProps> = ({ to, children }) => ( | ||
| <a href={to}>{children}</a> | ||
| <a href={sanitizeUrl(to)}>{children}</a> | ||
| ); |
superset-frontend/src/utils/pathUtils.ts
Outside changed files
| @@ -19,2 +19,3 @@ | ||
| import { applicationRoot } from 'src/utils/getBootstrapData'; | ||
| import { sanitizeUrl } from 'src/utils/sanitizeUtils'; | ||
|
|
||
| @@ -26,3 +27,4 @@ | ||
| export function ensureAppRoot(path: string): string { | ||
| return `${applicationRoot()}${path.startsWith('/') ? path : `/${path}`}`; | ||
| const sanitizedPath = path.startsWith('/') ? path : `/${path}`; | ||
| return sanitizeUrl(`${applicationRoot()}${sanitizedPath}`); | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION