Target Fixer API on API Layer and modernize #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update to the new Fixer API endpoint on API Layer - Re-add support for changing base currency. - Always use TLS encrypted endpoint, since this is once again supported by Free Plan. - Add new API function, available_currencies(), for listing supported currency symbols. - Replace unit tests based on nosetest with unit tests based on pytest (nose is not supported by modern Python 3 versions). - Remove support for Python 2. - Add type hints for all methods. - Changed dependencies listed in requirements.txt to be type >= instead of ==. Fixes amatellanes#39
Author
|
Hi @amatellanes, Is there any chance you will have a look at this pull request for me? |
|
Can you approve pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39