[awscontainerinsightreceiver] Enable usage of user defined collection interval in awscontainerinsightreceiver#319
Closed
TravisStark wants to merge 1 commit intoaws-cwa-devfrom
Closed
Conversation
cbfcbf8 to
f98329d
Compare
0500d6c to
e5cbfff
Compare
agarakan
reviewed
Jun 12, 2025
...ver/awscontainerinsightskueuereceiver/internal/kueuescraper/kueue_prometheus_scraper_test.go
Show resolved
Hide resolved
receiver/awscontainerinsightskueuereceiver/internal/kueuescraper/kueue_prometheus_scraper.go
Outdated
Show resolved
Hide resolved
79e3a20 to
bf561fd
Compare
agarakan
previously approved these changes
Jun 17, 2025
bf561fd to
5166708
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
ec0f3fd to
7d8a3c7
Compare
sky333999
reviewed
Jul 15, 2025
Author
|
Making a change in the Agent to set the default collection interval to -1, this will be used to infer whether the collection interval was supplied by the config or not |
66ed9ef to
2cefec4
Compare
80ce9ab to
c826814
Compare
5561c58 to
2e41d3b
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
2e41d3b to
1836172
Compare
…s receivers and sets fallback defaultCollectionInterval
1836172 to
81f2c5d
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Container Insights supports configuring a collection interval via the CWAgent json config that dictates how often the metrics should be collected from the various sources such as cadvisor.
The collection internal is not used for all the sources the metrics are retrieved from, including:
This change adjusts the containerinsights receiver to pass the CollectionInterval defined in the receiver config on to each scraper.
(metrics_collection_interval in CW Agent config)
opentelemetry-collector-contrib/receiver/awscontainerinsightreceiver/config.go
Line 19 in cb251fe
opentelemetry-collector-contrib/receiver/awscontainerinsightskueuereceiver/config.go
Line 13 in cb251fe
Note: For EFA, the original default collection interval value of 20s will be used if:
Testing
Tested on an EKS Cluster running GPU and Neuron.
Changed CollectionInterval to 30.
Count of metrics increased from 1 per minute to 2 per minute.
Graph of DCGM Exporter metrics count with multiple collection intervals specified:
15s, 30s, 60s, and not-specified (defaults to 60s)