Skip to content

Comments

[receiver/awsxrayreceiver] fix span kind when translating segment with parent ID#384

Merged
sky333999 merged 3 commits intoamazon-contributing:aws-cwa-devfrom
bjrara:xray-fix
Dec 16, 2025
Merged

[receiver/awsxrayreceiver] fix span kind when translating segment with parent ID#384
sky333999 merged 3 commits intoamazon-contributing:aws-cwa-devfrom
bjrara:xray-fix

Conversation

@bjrara
Copy link

@bjrara bjrara commented Nov 19, 2025

Description

Backport open-telemetry#44404

Link to tracking issue

Fixes

Testing

Documentation

wangzlei
wangzlei previously approved these changes Nov 21, 2025
Copy link
Collaborator

@wangzlei wangzlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mxiamxia
mxiamxia previously approved these changes Nov 25, 2025
sky333999
sky333999 previously approved these changes Nov 28, 2025
sky333999
sky333999 previously approved these changes Dec 3, 2025
mxiamxia
mxiamxia previously approved these changes Dec 3, 2025
wangzlei
wangzlei previously approved these changes Dec 3, 2025
@bjrara
Copy link
Author

bjrara commented Dec 3, 2025

Apart from govulncheck job failures, one unit test failed that didn't seem to be relevant to my change.

=== FAIL: . TestExtensionIntegrityWithPostgres (20.54s)
ERROR rerun aborted because previous run had a suspected panic and some test may not have run
    extension_test.go:58: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/storage/dbstorage/extension_test.go:58
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/storage/dbstorage/extension_test.go:52
        	Error:      	Received unexpected error:
        	            	failed to connect to `user=root database=db`: 127.0.0.1:32769 (127.0.0.1): failed to receive message: read tcp 127.0.0.1:49102->127.0.0.1:32769: read: connection reset by peer
        	Test:       	TestExtensionIntegrityWithPostgres
panic: runtime error: invalid memory address or nil pointer dereference [recovered, repanicked]

@bjrara
Copy link
Author

bjrara commented Dec 3, 2025

I'll leave it to the team to handle the transit failures.

@sky333999 sky333999 merged commit a9cb961 into amazon-contributing:aws-cwa-dev Dec 16, 2025
273 of 274 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants