Skip to content

[receiver/podmanreceiver] Fix flaky TestEventLoopHandles #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bhavya76 wants to merge 1 commit into
base: aws-cwa-dev
Choose a base branch
from
Draft

[receiver/podmanreceiver] Fix flaky TestEventLoopHandles #621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions receiver/podmanreceiver/podman_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,12 @@ func TestEventLoopHandlesError(t *testing.T) {
go cli.containerEventLoop(ctx)
defer cancel()

assert.Eventually(t, func() bool {
assert.EventuallyWithT(t, func(tt *assert.CollectT) {
for _, l := range logs.All() {
assert.Contains(t, l.Message, "Error watching podman container events")
assert.Contains(t, l.ContextMap()["error"], "EOF")
assert.Contains(tt, l.Message, "Error watching podman container events")
assert.Contains(tt, l.ContextMap()["error"], "EOF")
}
return len(logs.All()) > 0
assert.NotEmpty(tt, logs.All())
}, 1*time.Second, 1*time.Millisecond, "failed to find desired error logs.")

finished := make(chan struct{})
Expand Down Expand Up @@ -182,18 +182,18 @@ func TestEventLoopHandles(t *testing.T) {

eventChan <- event{ID: "c1", Status: "start"}

assert.Eventually(t, func() bool {
assert.EventuallyWithT(t, func(tt *assert.CollectT) {
cli.containersLock.Lock()
defer cli.containersLock.Unlock()
return assert.Len(t, cli.containers, 1)
assert.Len(tt, cli.containers, 1)
}, 1*time.Second, 1*time.Millisecond, "failed to update containers list.")

eventChan <- event{ID: "c1", Status: "died"}

assert.Eventually(t, func() bool {
assert.EventuallyWithT(t, func(tt *assert.CollectT) {
cli.containersLock.Lock()
defer cli.containersLock.Unlock()
return assert.Empty(t, cli.containers)
assert.Empty(tt, cli.containers)
}, 1*time.Second, 1*time.Millisecond, "failed to update containers list.")
}

Expand Down
Loading