Add clang-format check GitHub Action for changed C/C++ files - #41
Merged
bibrakc merged 1 commit intoJul 30, 2026
Merged
Conversation
NVIDIA/nccl upstream runs no GitHub Actions, so this fork has had no automated clang-format enforcement on pull requests. Add a workflow that, on PRs and pushes to master/dev/staging, checks only the added/modified/ renamed .cc/.cu/.cuh/.h files under src/ using clang-format in check mode (--dry-run --Werror). Pre-existing formatting in files a change does not touch never blocks the change. - Installs a pinned clang-format 22.1.2 (matches MIN_VERSION in maint/run-clang-format.sh) via pip for a deterministic CI version. - Honors the top-level .clang-format-ignore (clang-format skips ignored paths even when listed explicitly).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NVIDIA/nccl upstream runs no GitHub Actions, so this fork has had no automated clang-format enforcement on pull requests. Add a workflow that, on PRs and pushes to master/dev/staging, checks only the added/modified/ renamed .cc/.cu/.cuh/.h files under src/ using clang-format in check mode (--dry-run --Werror). Pre-existing formatting in files a change does not touch never blocks the change.