Fix --peano argument for C++ aircc binary#23
Merged
Conversation
The C++ aircc uses LLVM CommandLine parsing which treats "--peano" as a flag expecting the next argument as its value, consuming the input file path. Use "--peano=" to explicitly pass an empty string value so the input MLIR file is correctly parsed as a positional argument. The previous "--peano " with trailing space worked with Python aircc which stripped whitespace during argument parsing, but the C++ binary requires the = syntax for empty-value options. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes --peano argument passing when invoking the C++ aircc binary so it no longer consumes the input MLIR path as the option value.
Changes:
- Update
airccinvocation to pass an explicit empty value for--peanovia--peano=.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
erwei-xilinx
added a commit
that referenced
this pull request
Mar 20, 2026
Pick up mlir-air PR #1448 which adds PEANO_INSTALL_DIR environment variable fallback to C++ aircc, complementing the --peano= fix on the triton-xdna side (PR #23). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--peanoargument passing broken by the C++ aircc switch in Switch from Python aircc to C++ aircc binary #22"--peano" + " "(trailing space) worked with Python aircc which stripped whitespace, but the C++ LLVM CommandLine parser treats--peanoas expecting the next argument as its value, consuming the input file path"--peano="to explicitly pass an empty string valueTest plan
🤖 Generated with Claude Code