Update triton-shared submodule; remove deprecated TritonToLinalg pass#8
Merged
Merged
Conversation
erwei-xilinx
force-pushed
the
update-triton-shared-rm-triton-to-linalg
branch
from
6d16210 to
06e2d42
Compare
Update triton_shared submodule from 1af6a5f to 209a064 (latest facebookincubator/triton-shared main), which removes the deprecated monolithic TritonToLinalg pass. Regenerate triton_shared.patch to remove redundant TritonToLinalg deletion hunks now handled upstream. The amd_triton_npu backend exclusively uses --triton-to-linalg-experimental (TritonArithToLinalg + TritonToLinalgExperimental), so this removal has no functional impact. Also update README triton-shared link to point to the facebookincubator fork. Tested: full build + matmul on NPU hardware (AIE2) — identical results to unmodified main. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
third_party/triton_sharedsubmodule from1af6a5fto209a064(latest facebookincubator/triton-shared main)triton_shared.patch— removes ~5500 lines of redundant TritonToLinalg deletion hunks now handled upstreamThe upstream facebookincubator/triton-shared merged PR #1 which removes the deprecated monolithic
TritonToLinalgpass. Our backend exclusively uses--triton-to-linalg-experimental(compiler.py:78), so this has no functional impact.Test plan
ninja -Cbuild reapply-patches)pip install . --no-build-isolationwith venv per README)🤖 Generated with Claude Code