DLP: Added version API#2
Closed
abhirams-amd wants to merge 3 commits into
Closed
Conversation
abhirams-amd
commented
Sep 19, 2025
abhirams-amd
left a comment
abhirams-amd
left a comment
Contributor
Author
There was a problem hiding this comment.
Some changes required
abhirams-amd
added a commit
to abhirams-amd/aocl-dlp-dev
that referenced
this pull request
Sep 19, 2025
This commit addresses amd#2 (comment) Signed-off-by: Abhiram S <abhiram.s@amd.com>
abhirams-amd
force-pushed
the
u/abhirams/pr/version
branch
2 times, most recently
from
f43c36f to
e2f7e1d
Compare
| dlp_version_query(int* major, int* minor, int* patch) | ||
| { | ||
| if (major) | ||
| *major = atoi(AOCL_DLP_VERSION_MAJOR); |
Collaborator
There was a problem hiding this comment.
Please avoid using atoi to convert string to integer.
Signed-off-by: Abhiram S <abhiram.s@amd.com>
This commit addresses amd#2 (comment) Signed-off-by: Abhiram S <abhiram.s@amd.com>
Signed-off-by: Abhiram S <abhiram.s@amd.com>
abhirams-amd
force-pushed
the
u/abhirams/pr/version
branch
from
e2f7e1d to
5487fcb
Compare
Collaborator
|
We merged in internal repo and will be pushed to public in next dev branch upstreaming. |
Contributor
Author
|
Thanks @BhaskarNallani , I will close this PR |
BhaskarNallani
pushed a commit
that referenced
this pull request
Sep 29, 2025
DLP: Added version API DLP: Remove un-necessary variables CMake: Change version to literal from string #2 --------- Signed-off-by: Abhiram S <abhiram.s@amd.com>
BhaskarNallani
pushed a commit
that referenced
this pull request
Jan 3, 2026
DLP: Added version API DLP: Remove un-necessary variables CMake: Change version to literal from string #2 --------- Signed-off-by: Abhiram S <abhiram.s@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should add an API with which we can get version of the library.