feat(ui): policy alert cards, notifications, and durable receipts#1006
Closed
dislovelhl wants to merge 2 commits intoamd:mainfrom
Closed
feat(ui): policy alert cards, notifications, and durable receipts#1006dislovelhl wants to merge 2 commits intoamd:mainfrom
dislovelhl wants to merge 2 commits intoamd:mainfrom
Conversation
Rebuild the current PR amd#952 delta directly on top of the latest amd/main, preserve the policy-alert persistence fix, and carry forward the quality-gated local branch state that passes Python, Electron, and web UI build checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
documentation
dislovelhl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #952 with the same policy-alert UI delta rebuilt directly on top of the latest
main, plus the persistence-gap and cleanup follow-ups from review. Before this refresh, the branch was dirty against upstream and blocked receipts could still disappear or duplicate across provisional-message replacement and setup/error cleanup paths. After this update, policy BLOCK decisions stay durable across reloads and stream error paths, and the branch is conflict-free on the current base.Test plan
PYTHONPATH=/home/martin/code/gaia-acgs/.worktrees/pr952-fix/src python -m pytest tests/unit/chat/ui/test_database.py tests/unit/chat/ui/test_utils_helpers.py::TestMessageToResponse::test_agent_steps_preserves_policy_alert_fields tests/integration/test_chat_ui_integration.py -k 'policy_alert or replace_message or stream_cleanup_after_setup_exception or stream_cleanup_when_thread_start_fails' -q\n- [x]git diff --check\n- [x]python -m black --check src/gaia/ui/_chat_helpers.py src/gaia/ui/database.py tests/integration/test_chat_ui_integration.py tests/unit/chat/ui/test_database.py tests/unit/chat/ui/test_utils_helpers.py\n- [x]python -m isort --check-only src/gaia/ui/_chat_helpers.py src/gaia/ui/database.py tests/integration/test_chat_ui_integration.py tests/unit/chat/ui/test_database.py tests/unit/chat/ui/test_utils_helpers.py\n- [x]cd src/gaia/apps/webui && npm run build\n- [x]cd tests/electron && CI=true npm test -- --runInBand