ci(docs): skip fastmcp.me in external link check (incomplete TLS cert chain)#1550
Closed
itomek wants to merge 1 commit into
Closed
ci(docs): skip fastmcp.me in external link check (incomplete TLS cert chain)#1550itomek wants to merge 1 commit into
itomek wants to merge 1 commit into
Conversation
… chain) fastmcp.me serves an incomplete TLS certificate chain, so Python's urllib raises CERTIFICATE_VERIFY_FAILED on every run while browsers/curl succeed. The link in docs/plans/agent-ui-agent-capabilities-plan.md has therefore failed the 'Verify external URLs' job on every docs-touching PR since #1419. Add the domain to SKIP_DOMAINS alongside the other automated-request blockers so the check reflects real breakage, not a CI-only cert quirk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
The "Verify external URLs" CI job (
check_doc_links.yml) has failed on every docs-touching PR since #1419, blocking a clean check on otherwise-good documentation changes — including the v0.21.0 release PR (#1548).The cause isn't a dead link.
docs/plans/agent-ui-agent-capabilities-plan.md:363citeshttps://fastmcp.me/blog/top-10-most-popular-mcp-servers; that page is live, but the server presents an incomplete TLS certificate chain, so Python'surllibraises[SSL: CERTIFICATE_VERIFY_FAILED]on every run (browsers andcurlsucceed because they fetch the missing intermediate certs). It's a CI-only cert quirk, not real breakage.This adds
fastmcp.meto the checker's existingSKIP_DOMAINSallowlist — the same mechanism already used formarketplace.visualstudio.com,www.npmjs.com, andplatform.openai.com, all of which break automated requests — so the check reflects genuine link rot instead of failing red on a domain it can't validate.Test plan
should_skip("https://fastmcp.me/blog/...")returnsTruepython util/check_doc_links.py --external-only --max-workers 5→Broken: 0,PASSED(was: 1 broken onfastmcp.me)amd.com/en/developer.htmlitem is a transient timeout warning, not a failure — left as-isSKIP_DOMAINS;util/is outside the black/isort lint scope (LINT_DIRS = ["src/gaia", "tests"]), so no formatting impact