Make SkillSpector advisory + only scan changed skills#68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two quick changes to SkillSpector CI:
Only scan what changed. Instead of re-scanning every skill on every run, the discovery job now diffs against the base and picks only the skills that actually changed. If the scanning machinery itself changes (the workflow, gate, or allowlist), it scans everything.
Advisory only: no more blocking. SkillSpector findings no longer fail CI. When a skill has un-allowlisted HIGH/CRITICAL findings (or the scan errors), we raise a ::warning:: annotation + a job-summary entry so it's clearly flagged on the PR, but the check stays green and the merge isn't blocked. It only goes red on a genuine infra crash (runner/setup failure). This is the same strategy used by similar repos.