Add real time pmf npu metrics for xrt-smi power estimate. #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinitAmd
force-pushed
the
npu_matix
branch
2 times, most recently
from
6f9f36b to
8c62136
Compare
VinitAmd
changed the title
VinitAmd
changed the title
houlz0507
reviewed
Oct 7, 2025
houlz0507
reviewed
Oct 8, 2025
VinitAmd
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements real-time NPU power metrics retrieval using the AMD PMF (Power Management Framework) interface for kernel versions above 6.18.0. The changes enable xrt-smi to provide actual power estimates instead of placeholder values.
- Adds integration with AMD PMF NPU metrics API
- Implements power estimate query functionality with kernel version compatibility
- Removes unused clock frequency getter functions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/driver/amdxdna/aie2_smu.c | Replaces removed clock frequency functions with new NPU metrics and power estimate retrieval functions |
| src/driver/amdxdna/aie2_pci.h | Updates function declarations to match new power metric interface and adds required headers |
| src/driver/amdxdna/aie2_pci.c | Integrates power estimate retrieval into sensor query logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: vinit shukla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.