Adding further aie4 shim test support #895
Conversation
Signed-off-by: Hayden Laccabue <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR extends AIE4 support in the shim test suite by introducing a new debug buffer type (XRT_BO_USE_UC_DEBUG) and broadening test coverage from AIE2-specific to general AIE platform support. The changes enable debug buffer operations to work correctly on AIE4 devices while maintaining backward compatibility with AIE2.
- Introduced XRT_BO_USE_UC_DEBUG buffer type for AIE4 debug operations
- Extended test coverage from AIE2-only to all AIE platforms for several test cases
- Updated buffer creation logic to conditionally use appropriate debug flags based on device type
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/shim_test/shim_test.cpp | Conditionally selects debug buffer flags based on AIE4 detection and broadens test filters from AIE2-specific to general AIE support |
| src/shim/buffer.cpp | Adds mapping for new XRT_BO_USE_UC_DEBUG buffer type to firmware debug buffer type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| case XRT_BO_USE_UC_DEBUG: | ||
| return AMDXDNA_FW_BUF_DEBUG; |
There was a problem hiding this comment.
The new XRT_BO_USE_UC_DEBUG case returns the same firmware buffer type as XRT_BO_USE_DEBUG. Add a comment explaining why both buffer use types map to the same firmware type, or if they should have different behaviors.
1 participant
No description provided.