Skip to content

chore: update devDependencies and peerDependencies#370

Closed
vostrypet wants to merge 1 commit into
americanexpress:mainfrom
vostrypet:feature/update-jest-dependency
Closed

chore: update devDependencies and peerDependencies#370
vostrypet wants to merge 1 commit into
americanexpress:mainfrom
vostrypet:feature/update-jest-dependency

Conversation

@vostrypet

@vostrypet vostrypet commented Jun 19, 2025 •
edited
Loading

Copy link
Copy Markdown
  • Bump @semantic-release/changelog from 5.0.0 to 6.0.0
  • Bump @semantic-release/git from 9.0.0 to 10.0.0
  • Downgrade eslint-config-amex from 7.0.0 to 6.0.0
  • Bump jest and jest-snapshot from 29.x to 30.x
  • Bump semantic-release from 17.0.4 to 24.2.5
  • Update peerDependency for jest to ^30.0.0

Description

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Jest-Image-Snapshot?

@vostrypet
chore: update devDependencies and peerDependencies
3df7795 
- Bump @semantic-release/changelog from 5.0.0 to 6.0.0
- Bump @semantic-release/git from 9.0.0 to 10.0.0
- Downgrade eslint-config-amex from 7.0.0 to 6.0.0
- Bump jest and jest-snapshot from 29.x to 30.x
- Bump semantic-release from 17.0.4 to 24.2.5
- Update peerDependency for jest to ^30.0.0
@vostrypet vostrypet requested a review from a team as a code owner June 19, 2025 10:43
@CLAassistant

CLAassistant commented Jun 19, 2025

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vostrypet

vostrypet commented Jul 7, 2025

Copy link
Copy Markdown
Author

The goal of this pull request is to upgrade dependencies, specifically to enable upgrading to Jest 30 in the project. Currently, it's not possible to upgrade to Jest 30 due to the existing constraint "jest": ">=20 <=29" in the dependencies.

This is a breaking change because Jest 30 introduces changes to testing methods, which required modifications to the existing tests that were not compatible with version 20.x. The test updates were necessary to ensure compatibility with the new Jest version.

code-forger
code-forger requested changes Jul 19, 2025
View reviewed changes

@code-forger code-forger left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reword your commit message to include the BREAKING CHANGE: line as specified below:

<type>(<scope>): <subject>
<BLANK LINE>
<body>
<BLANK LINE>
BREAKING CHANGE: <description>

@project0

project0 commented Sep 10, 2025

Copy link
Copy Markdown

any update on this?

1 similar comment
@vielhuber

vielhuber commented Nov 19, 2025

Copy link
Copy Markdown

any update on this?

@smackfu

smackfu commented Jan 14, 2026

Copy link
Copy Markdown
Member

FYI merged #373 did the jest upgrade part of this.

@vostrypet vostrypet closed this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-forger code-forger code-forger requested changes

@giulianok giulianok giulianok approved these changes

@ddwivedi551 ddwivedi551 ddwivedi551 approved these changes

Assignees

No one assigned

Labels

one-app-team-review-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vostrypet @CLAassistant @project0 @vielhuber @smackfu @code-forger @giulianok @ddwivedi551