Add function to update W&B run name with sequence number #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change by reintroducing a function that updates the W&B run name by appending a sequence number.
- Reformats the all declaration in init.py for better readability
- Introduces update_run_name_with_sequence in amp_on_policy_runner.py to retrieve runs via wandb’s API and update the run name accordingly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| amp_rsl_rl/utils/init.py | Reformats the all list for enhanced readability |
| amp_rsl_rl/runners/amp_on_policy_runner.py | Adds a function to update the W&B run name with a sequence number to replicate previous behavior |
Comments suppressed due to low confidence (1)
amp_rsl_rl/runners/amp_on_policy_runner.py:257
- The inline comment appears inconsistent; consider updating it to accurately reflect that the numeric suffix extracted from 'prefix564' should be '564'.
numeric_suffix = run.name[len(prefix):] # e.g., from "prefix564", get "542"
Co-authored-by: Copilot <[email protected]>
|
If leggedrobotics/rsl_rl#80 got merged, this is not required. |
Giulero
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to update the W&B run name, reverting the change made in leggedrobotics/rsl_rl@b9f9e69, which renamed the run using the log folder name.