Skip to content

Conversation

@dinger1986
Copy link
Collaborator

changes for linux agents install

@codecov
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.20%. Comparing base (0528ecb) to head (c00caf7).
⚠️ Report is 412 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1809   +/-   ##
========================================
  Coverage    79.20%   79.20%           
========================================
  Files          138      138           
  Lines         9664     9664           
========================================
  Hits          7654     7654           
  Misses        2010     2010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dinger1986
Copy link
Collaborator Author

follows on from #1796 which was removed as I needed to tidy up my repos

@dinger1986
Copy link
Collaborator Author

change optional install dir

@dinger1986
Copy link
Collaborator Author

@wh1te909 I can remove this line https://github.com/dinger1986/tacticalrmm/blob/c00caf7d11bcc4b4e8ee684914de23ca385ecd40/api/tacticalrmm/core/agent_linux.sh#L28 as it can be set by a variable, it was more to catch the instance where someone forgets to set it and then the binary doesnt get removed on uninstall. What I think Ill do is add it to PATH if its a custom folder and then use which to find it for uninstall, does that sound a good idea?

@wh1te909
Copy link
Member

@dinger1986 you need to make the appropriate changes in the agent code base, just like how we handle other optional install flags/settings

@dinger1986
Copy link
Collaborator Author

Ah ok, I get you! I'll do some reading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants