Skip to content

feat: add commonLabels and podLabels support#120

Merged
tazarov merged 2 commits into
amikos-tech:mainfrom
ianhundere:feat/common-labels-pod-labels
Feb 17, 2026
Merged

feat: add commonLabels and podLabels support#120
tazarov merged 2 commits into
amikos-tech:mainfrom
ianhundere:feat/common-labels-pod-labels

Conversation

@ianhundere

Copy link
Copy Markdown
Contributor

Summary

  • Add commonLabels value — merged into chart.labels, applied to all resource metadata (StatefulSet, Service, Ingress, test Jobs)
  • Add podLabels value — applied to pod template labels alongside chart.labels (does not affect spec.selector.matchLabels)

This is a common pattern in the Helm ecosystem for enabling operators to apply organizational labels (e.g., team, environment, cost-center) without forking or wrapping the chart.

Reference implementations:

Changes

File Change
values.yaml Add commonLabels: {} and podLabels: {}
templates/_helpers.tpl Append commonLabels to chart.labels template
templates/statefulset.yaml Add podLabels to pod template metadata

Backwards compatible

Both values default to {} — no change in behavior for existing users. matchLabels is unaffected (uses chart.selectorLabels only).

@ianhundere ianhundere requested a review from tazarov as a code owner February 12, 2026 01:16
ianhundere and others added 2 commits February 17, 2026 10:45
Add `commonLabels` and `podLabels` values for injecting custom labels
into chart resources.

- `commonLabels` — merged into `chart.labels`, applied to all resource
  metadata (StatefulSet, Service, Ingress, test Jobs)
- `podLabels` — applied to pod template labels alongside chart.labels
  (does not affect `spec.selector.matchLabels`)

This is a common pattern in the Helm ecosystem (see metrics-server,
ingress-nginx, cert-manager) that enables operators to apply
organizational labels without forking or wrapping the chart.
- Add chart.labels to all ConfigMaps and Secrets in config.yaml
- Add chart.labels to volumeClaimTemplates PVC metadata
- Bump chart version 0.1.25 -> 0.1.26
- Document commonLabels and podLabels in README
@tazarov tazarov force-pushed the feat/common-labels-pod-labels branch from 931a47a to c6c9e85 Compare February 17, 2026 08:53
@tazarov

tazarov commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

@ianhundere thanks for this. I've added labels to secrets/configmaps/volume templates + updated docs to surface the labels value

@tazarov tazarov merged commit 22a3700 into amikos-tech:main Feb 17, 2026
7 of 8 checks passed
@ianhundere

Copy link
Copy Markdown
Contributor Author

hey, thanks for merging this! any chance you could cut a new release so we can pick it up? we've been running a wrapper _helpers.tpl override to inject labels and would love to drop it

@tazarov

tazarov commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

@ianhundere, sure thing. I'll cut a new release in a few minutes.

@tazarov

tazarov commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

@ianhundere done 0.2.0 of the chart is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants